webrtc-internals: dont remove tab

webrtc-internals: dont remove tab

instead of removing the tab when a peerconnection is garbage collected
this adds a symbol which removes the tab on click.

BUG=416876
Review-Url: https://codereview.chromium.org/2739443002
Cr-Commit-Position: refs/heads/master@{#455743}
Committed: https://chromium.googlesource.com/chromium/src/+/b31e6f5fc2cae4ce8efdb57eb995a0c2e583dd75

[fippo, 2017-03-06 19:43:03]

Description was changed from

==========
webrtc-internals: dont remove tab

instead of removing the tab when a peerconnection is garbage collected
this adds a symbol which removes the tab on click.

BUG=416876
==========

to

==========
webrtc-internals: dont remove tab

instead of removing the tab when a peerconnection is garbage collected
this adds a symbol which removes the tab on click.

BUG=416876
==========

[fippo, 2017-03-06 19:43:04]

philipp.hancke@googlemail.com changed reviewers:
+ guidou@chromium.org

[Guido Urdaneta, 2017-03-09 10:50:55]

Tested manually and it runs fine. Thanks for this!

[Guido Urdaneta, 2017-03-09 14:23:31]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2017-03-09 14:23:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 14:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 14:23:47]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Guido Urdaneta, 2017-03-09 14:25:54]

guidou@chromium.org changed reviewers:
+ tommi@chromium.org

[Guido Urdaneta, 2017-03-09 14:27:03]

tommi@: can you take a look?

[tommi (sloooow) - chröme, 2017-03-09 14:34:11]

rs lgtm

[tommi (sloooow) - chröme, 2017-03-09 14:34:16]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2017-03-09 14:34:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 14:45:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489070056050390, "parent_rev":
"e42b6912ec7a355b4575435a21e618e7aa277e42", "commit_rev":
"b31e6f5fc2cae4ce8efdb57eb995a0c2e583dd75"}

[commit-bot: I haz the power, 2017-03-09 14:46:02]

Description was changed from

==========
webrtc-internals: dont remove tab

instead of removing the tab when a peerconnection is garbage collected
this adds a symbol which removes the tab on click.

BUG=416876
==========

to

==========
webrtc-internals: dont remove tab

instead of removing the tab when a peerconnection is garbage collected
this adds a symbol which removes the tab on click.

BUG=416876

Review-Url: https://codereview.chromium.org/2739443002
Cr-Commit-Position: refs/heads/master@{#455743}
Committed:
https://chromium.googlesource.com/chromium/src/+/b31e6f5fc2cae4ce8efdb57eb995...
==========

[commit-bot: I haz the power, 2017-03-09 14:46:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b31e6f5fc2cae4ce8efdb57eb995...

[fserb, 2017-03-09 16:22:34]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2745433004/ by fserb@chromium.org.

The reason for reverting is: This is breaking some Mac builds
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests....