[wasm][asm.js] Fix asm.js in tests to be more strictly valid.

[wasm][asm.js] Fix asm.js in tests to be more strictly valid.

These tests fail with the new asm.js parser, because they are invalid under
a more strict reading of the spec.

NOTE: These also fail to validate when run in Firefox.

BUG=v8:4203
BUG=v8:6090
R=aseemgarg@chromium.org,eholk@chromium.org

Review-Url: https://codereview.chromium.org/2745393002
Cr-Commit-Position: refs/heads/master@{#43803}
Committed: https://chromium.googlesource.com/v8/v8/+/8c1af20baf74cfa286833fb4b4b67b31ad34662b

[bradnelson, 2017-03-14 04:00:38]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 04:00:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2017-03-14 04:01:48]

Sending this out as a prereq to landing the new parser.

Here's the complete change for context (will land it parts, with more small
tests):
https://codereview.chromium.org/2733743002/

[commit-bot: I haz the power, 2017-03-14 04:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 04:26:44]

Dry run: This issue passed the CQ dry run.

[Eric Holk, 2017-03-14 17:08:51]

l-g-t-m (I'm not an owner so you'll need a real lg from someone else).

https://codereview.chromium.org/2745393002/diff/1/test/mjsunit/wasm/asm-wasm-...
File test/mjsunit/wasm/asm-wasm-literals.js (right):

https://codereview.chromium.org/2745393002/diff/1/test/mjsunit/wasm/asm-wasm-...
test/mjsunit/wasm/asm-wasm-literals.js:80: function f0() { return +(0 >>> 0); }
The + is here to convert these into doubles, right?

[aseemgarg, 2017-03-14 19:41:54]

lgtm

[bradn, 2017-03-14 20:15:13]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2017-03-14 20:15:13]

https://codereview.chromium.org/2745393002/diff/1/test/mjsunit/wasm/asm-wasm-...
File test/mjsunit/wasm/asm-wasm-literals.js (right):

https://codereview.chromium.org/2745393002/diff/1/test/mjsunit/wasm/asm-wasm-...
test/mjsunit/wasm/asm-wasm-literals.js:80: function f0() { return +(0 >>> 0); }
On 2017/03/14 17:08:50, Eric Holk wrote:
> The + is here to convert these into doubles, right?

Correct. The asm.js spec doesn't actually allow unsigned return values.

[bradn, 2017-03-14 20:15:21]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2017-03-14 20:15:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 20:17:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489522521693470, "parent_rev":
"39db77c6ec87dfd69c39488537dd2b2f743f8b17", "commit_rev":
"8c1af20baf74cfa286833fb4b4b67b31ad34662b"}

[commit-bot: I haz the power, 2017-03-14 20:17:10]

Description was changed from

==========
[wasm][asm.js] Fix asm.js in tests to be more strictly valid.

These tests fail with the new asm.js parser, because they are invalid under
a more strict reading of the spec.

NOTE: These also fail to validate when run in Firefox.

BUG=v8:4203
BUG=v8:6090
R=aseemgarg@chromium.org,eholk@chromium.org
==========

to

==========
[wasm][asm.js] Fix asm.js in tests to be more strictly valid.

These tests fail with the new asm.js parser, because they are invalid under
a more strict reading of the spec.

NOTE: These also fail to validate when run in Firefox.

BUG=v8:4203
BUG=v8:6090
R=aseemgarg@chromium.org,eholk@chromium.org

Review-Url: https://codereview.chromium.org/2745393002
Cr-Commit-Position: refs/heads/master@{#43803}
Committed:
https://chromium.googlesource.com/v8/v8/+/8c1af20baf74cfa286833fb4b4b67b31ad3...
==========

[commit-bot: I haz the power, 2017-03-14 20:17:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8c1af20baf74cfa286833fb4b4b67b31ad3...