Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2733743002: [wasm][asm.js] Asm.js -> wasm custom parser. (Closed)

Created:
3 years, 9 months ago by bradnelson
Modified:
3 years, 9 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Asm.js -> wasm custom parser. This CL captures a mostly complete asm.js lexer + parser + converter. We'll land it in pieces, but it's here for reference. BUG=v8:6090

Patch Set 1 #

Patch Set 2 : more works #

Patch Set 3 : fixed most lint #

Patch Set 4 : fixed heap #

Patch Set 5 : more works #

Patch Set 6 : passes unity benchmark #

Patch Set 7 : fix #

Patch Set 8 : fix warnings #

Patch Set 9 : fix #

Patch Set 10 : merge #

Patch Set 11 : merge #

Patch Set 12 : merge #

Patch Set 13 : fix #

Patch Set 14 : fix #

Patch Set 15 : fix #

Patch Set 16 : fix #

Patch Set 17 : fix #

Patch Set 18 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2738 lines, -60 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download
M src/asmjs/asm-js.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +88 lines, -42 lines 0 comments Download
A src/asmjs/asm-parser.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +217 lines, -0 lines 0 comments Download
A src/asmjs/asm-parser.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2354 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +7 lines, -0 lines 0 comments Download
M src/wasm/wasm-module-builder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +15 lines, -3 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 9 chunks +46 lines, -13 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 51 (51 generated)
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-14 03:44:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/100001
3 years, 9 months ago (2017-03-14 03:44:49 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-14 03:47:58 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24031)
3 years, 9 months ago (2017-03-14 03:47:59 UTC) #4
bradn
Description was changed from ========== [wasm][asm.js] Asm.js -> wasm parser. BUG= ========== to ========== [wasm][asm.js] ...
3 years, 9 months ago (2017-03-14 03:51:24 UTC) #5
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-14 03:54:28 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/120001
3 years, 9 months ago (2017-03-14 03:54:29 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-14 03:57:40 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/34085) v8_win_rel_ng on ...
3 years, 9 months ago (2017-03-14 03:57:41 UTC) #9
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-14 05:27:39 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/140001
3 years, 9 months ago (2017-03-14 05:27:45 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-14 05:32:14 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/18794)
3 years, 9 months ago (2017-03-14 05:32:15 UTC) #13
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-15 00:30:37 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/160001
3 years, 9 months ago (2017-03-15 00:30:44 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-15 00:32:33 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/34103) v8_linux64_verify_csa_rel_ng on ...
3 years, 9 months ago (2017-03-15 00:32:33 UTC) #17
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-15 03:59:39 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/180001
3 years, 9 months ago (2017-03-15 03:59:41 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-15 04:01:50 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/18260) v8_linux_nodcheck_rel_ng on ...
3 years, 9 months ago (2017-03-15 04:01:51 UTC) #21
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-15 04:08:47 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/200001
3 years, 9 months ago (2017-03-15 04:08:50 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-15 04:11:39 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24127) v8_win_rel_ng on ...
3 years, 9 months ago (2017-03-15 04:11:40 UTC) #25
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-15 04:11:55 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/220001
3 years, 9 months ago (2017-03-15 04:12:01 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-15 04:14:49 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/34180) v8_win_rel_ng on ...
3 years, 9 months ago (2017-03-15 04:14:50 UTC) #29
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-15 07:52:51 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/240001
3 years, 9 months ago (2017-03-15 07:53:05 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-15 07:56:31 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/24226)
3 years, 9 months ago (2017-03-15 07:56:32 UTC) #33
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-15 16:37:07 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/260001
3 years, 9 months ago (2017-03-15 16:37:09 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-15 16:40:19 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24204) v8_win_compile_dbg on ...
3 years, 9 months ago (2017-03-15 16:40:19 UTC) #37
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-16 23:43:31 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/280001
3 years, 9 months ago (2017-03-16 23:43:34 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-16 23:47:04 UTC) #40
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24333) v8_win_compile_dbg on ...
3 years, 9 months ago (2017-03-16 23:47:04 UTC) #41
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-16 23:59:27 UTC) #42
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/300001
3 years, 9 months ago (2017-03-16 23:59:35 UTC) #43
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-17 00:03:56 UTC) #44
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/14957)
3 years, 9 months ago (2017-03-17 00:03:57 UTC) #45
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-17 00:10:40 UTC) #46
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733743002/320001
3 years, 9 months ago (2017-03-17 00:10:46 UTC) #47
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-17 00:26:55 UTC) #48
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/14960) v8_linux64_gyp_rel_ng_triggered on ...
3 years, 9 months ago (2017-03-17 00:26:56 UTC) #49
bradnelson
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-17 00:39:33 UTC) #50
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 00:39:42 UTC) #51

Powered by Google App Engine
This is Rietveld 408576698