Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: test/mjsunit/wasm/asm-wasm.js

Issue 2745393002: [wasm][asm.js] Fix asm.js in tests to be more strictly valid. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/wasm/asm-wasm-literals.js » ('j') | test/mjsunit/wasm/asm-wasm-literals.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/wasm/asm-wasm.js
diff --git a/test/mjsunit/wasm/asm-wasm.js b/test/mjsunit/wasm/asm-wasm.js
index 6becaad6b706dea14d4b7a8d8c85800a5f3db6af..f5f57e989a046b03d865430c7ef930d4d825312a 100644
--- a/test/mjsunit/wasm/asm-wasm.js
+++ b/test/mjsunit/wasm/asm-wasm.js
@@ -78,7 +78,7 @@ function Float64Test() {
function caller() {
var a = 0.0;
- var ret = 0|0;
+ var ret = 0;
a = +sum(70.1,10.2);
if (a == 80.3) {
ret = 1|0;
@@ -416,7 +416,7 @@ function TestContinueInDoWhileFalse() {
function caller() {
do {
continue;
- } while (false);
+ } while (0);
return 47;
}
@@ -889,7 +889,7 @@ function TestInitFunctionWithNoGlobals() {
function caller() {
return 51;
}
- return {caller};
+ return {caller:caller};
}
assertWasm(51, TestInitFunctionWithNoGlobals);
@@ -1101,7 +1101,6 @@ function TestForeignFunctionMultipleUse() {
print("TestForeignFunctionMultipleUse...");
TestForeignFunctionMultipleUse();
-
function TestForeignVariables() {
function AsmModule(stdlib, foreign, buffer) {
"use asm";
@@ -1474,7 +1473,7 @@ assertWasm(3, TestAndNegative);
function TestNegativeDouble() {
"use asm";
function func() {
- var x = -(34359738368.25);
+ var x = -34359738368.25;
var y = -2.5;
return +(x + y);
}
@@ -1513,6 +1512,9 @@ assertWasm(-34359738370.75, TestNegativeDouble);
})();
+/*
+// TODO(bradnelson): Technically invalid, but useful to cover unicode, revises
+// and re-enable.
(function TestUnicodeExportKey() {
function Module() {
"use asm";
@@ -1526,6 +1528,7 @@ assertWasm(-34359738370.75, TestNegativeDouble);
assertEquals(42, m.Ñæ());
assertValidAsm(Module);
})();
+*/
function TestAndIntAndHeapValue(stdlib, foreign, buffer) {
« no previous file with comments | « no previous file | test/mjsunit/wasm/asm-wasm-literals.js » ('j') | test/mjsunit/wasm/asm-wasm-literals.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698