Use CSSProperties.json5 format for nonproperties as well.

Use CSSProperties.json5 format for nonproperties as well.

This patch modifies make_computed_style_base.py so that hardcoded
nonproperties use the same JSON format as CSSProperties.json5. The
list of dicts in NONPROPERTY_FIELDS has the same format and meaning
as the data in CSSProperties.json5.

This allows us to specify different templates for nonproperties.

This is prework for combining the code logic for properties and
nonproperties.

BUG=628043
Review-Url: https://codereview.chromium.org/2745023002
Cr-Commit-Position: refs/heads/master@{#457694}
Committed: https://chromium.googlesource.com/chromium/src/+/d56884370eecac968f54c5826958938d7c8f1a4c

[shend, 2017-03-13 06:38:37]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-03-13 06:38:37]

Hi Naina, PTAL :)

[nainar, 2017-03-13 07:20:05]

On 2017/03/13 at 06:38:37, shend wrote:
> Hi Naina, PTAL :)

Sorry someone with more experience here should take a look. Lacking context.

[shend, 2017-03-14 04:39:30]

shend@chromium.org changed reviewers:
+ meade@chromium.org
- nainar@chromium.org

[shend, 2017-03-14 04:39:30]

Hi Eddy, PTAL

[meade_UTC10, 2017-03-15 06:24:54]

lgtm with nits: Needs a clarification in a comment + updating the description a
little.

https://codereview.chromium.org/2745023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2745023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:20: {'name':
'unique', 'field_template': 'monotonic_flag'},
Can you please add something to the CL description of what this list of dicts is
doing?

https://codereview.chromium.org/2745023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:205: Create
a nonproperty field from a property dict and return the Field object.
What's a property dict? Need a comment or rewording to make it clearer that
you're referring to the contents of NONPROPERTY_FIELDS.

[shend, 2017-03-16 01:05:03]

Description was changed from

==========
Use CSSProperties.json5 format for nonproperties as well.

This patch modifies make_computed_style_base.py so that hardcoded
nonproperties use the same JSON format as CSSProperties.json5. This
allows us to specify different templates for nonproperties.

This is prework for combining the code logic for properties and
nonproperties.

BUG=628043
==========

to

==========
Use CSSProperties.json5 format for nonproperties as well.

This patch modifies make_computed_style_base.py so that hardcoded
nonproperties use the same JSON format as CSSProperties.json5. The
list of dicts in NONPROPERTY_FIELDS has the same format and meaning
as the data in CSSProperties.json5.

This allows us to specify different templates for nonproperties.

This is prework for combining the code logic for properties and
nonproperties.

BUG=628043
==========

[shend, 2017-03-16 01:58:48]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 01:59:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-03-16 02:08:01]

https://codereview.chromium.org/2745023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2745023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:20: {'name':
'unique', 'field_template': 'monotonic_flag'},
On 2017/03/15 at 06:24:54, Eddy wrote:
> Can you please add something to the CL description of what this list of dicts
is doing?

Done.

https://codereview.chromium.org/2745023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:205: Create
a nonproperty field from a property dict and return the Field object.
On 2017/03/15 at 06:24:54, Eddy wrote:
> What's a property dict? Need a comment or rewording to make it clearer that
you're referring to the contents of NONPROPERTY_FIELDS.

Done

[commit-bot: I haz the power, 2017-03-16 03:32:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 03:32:11]

Dry run: This issue passed the CQ dry run.

[shend, 2017-03-17 03:19:32]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-17 03:19:33]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2745023002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-03-17 03:19:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 05:26:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489720772760530,
"parent_rev": "ec7d62a479fe6625a2a20295e346bfe92d42417c", "commit_rev":
"d56884370eecac968f54c5826958938d7c8f1a4c"}

[commit-bot: I haz the power, 2017-03-17 05:27:28]

Description was changed from

==========
Use CSSProperties.json5 format for nonproperties as well.

This patch modifies make_computed_style_base.py so that hardcoded
nonproperties use the same JSON format as CSSProperties.json5. The
list of dicts in NONPROPERTY_FIELDS has the same format and meaning
as the data in CSSProperties.json5.

This allows us to specify different templates for nonproperties.

This is prework for combining the code logic for properties and
nonproperties.

BUG=628043
==========

to

==========
Use CSSProperties.json5 format for nonproperties as well.

This patch modifies make_computed_style_base.py so that hardcoded
nonproperties use the same JSON format as CSSProperties.json5. The
list of dicts in NONPROPERTY_FIELDS has the same format and meaning
as the data in CSSProperties.json5.

This allows us to specify different templates for nonproperties.

This is prework for combining the code logic for properties and
nonproperties.

BUG=628043

Review-Url: https://codereview.chromium.org/2745023002
Cr-Commit-Position: refs/heads/master@{#457694}
Committed:
https://chromium.googlesource.com/chromium/src/+/d56884370eecac968f54c5826958...
==========

[commit-bot: I haz the power, 2017-03-17 05:27:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d56884370eecac968f54c5826958...