Move naming related code in make_computed_style_base to name_utilities.

Move naming related code in make_computed_style_base to name_utilities.

Currently make_computed_style_base is sprinkled with a lot of code
related to variable names and method names. These are common pieces of
logic that can be reused by other generators as well.

This patch tidies up make_computed_style_base by moving naming logic
to name_utilities.py.

BUG=628043
Review-Url: https://codereview.chromium.org/2756113002
Cr-Commit-Position: refs/heads/master@{#458635}
Committed: https://chromium.googlesource.com/chromium/src/+/a6bfb94ddcb95eef883d62b3d65de8e13192e90c

[shend, 2017-03-17 04:15:30]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-03-17 04:15:31]

Hi Alan, PTAL

[alancutter (OOO until 2018), 2017-03-20 05:10:17]

https://codereview.chromium.org/2756113002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/name_utilities.py (right):

https://codereview.chromium.org/2756113002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/name_utilities.py:138: # High level API
Not sure if these comment headers really add much.

https://codereview.chromium.org/2756113002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/name_utilities.py:141: def
enumeration_name(name):
Should this be property_name?

https://codereview.chromium.org/2756113002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/name_utilities.py:145: def
enumerator_name(name):
enumeration and enumerator are a bit academic as terminology. I'd just call them
enum_type_name and enum_value_name for clarity.

[shend, 2017-03-20 21:24:34]

Description was changed from

==========
Move naming related code in make_computed_style_base to name_utilities.

Currently make_computed_style_base is sprinkled with a lot of code
related to variable names and method names. These are common pieces of
logic that can be reused by other generators as well.

This patch tidies up make_computed_style_base by moving naming logic
to name_utilities.py. It also refactors the code to simplify the
handling of names.

BUG=628043
==========

to

==========
Move naming related code in make_computed_style_base to name_utilities.

Currently make_computed_style_base is sprinkled with a lot of code
related to variable names and method names. These are common pieces of
logic that can be reused by other generators as well.

This patch tidies up make_computed_style_base by moving naming logic
to name_utilities.py.

BUG=628043
==========

[shend, 2017-03-20 21:26:12]

Split CL and addressed comments, PTAL again Alan :)

https://codereview.chromium.org/2756113002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/name_utilities.py (right):

https://codereview.chromium.org/2756113002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/name_utilities.py:138: # High level API
On 2017/03/20 at 05:10:16, alancutter wrote:
> Not sure if these comment headers really add much.

Fixed.

https://codereview.chromium.org/2756113002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/name_utilities.py:141: def
enumeration_name(name):
On 2017/03/20 at 05:10:16, alancutter wrote:
> Should this be property_name?

I'm trying to keep this generic for any type of code, not just style code.

https://codereview.chromium.org/2756113002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/name_utilities.py:145: def
enumerator_name(name):
On 2017/03/20 at 05:10:16, alancutter wrote:
> enumeration and enumerator are a bit academic as terminology. I'd just call
them enum_type_name and enum_value_name for clarity.

Good idea. Done.

[shend, 2017-03-20 22:02:39]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 22:03:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:06:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[shend, 2017-03-20 22:18:10]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 22:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:41:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:41:27]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[shend, 2017-03-20 23:12:23]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:13:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 00:57:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 00:57:34]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-03-21 04:56:47]

lgtm

https://codereview.chromium.org/2756113002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2756113002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:210:
name_for_methods = property_['name']
It's weird to call this name_for_methods, it should just be called name since
it's used for more than just methods.

[shend, 2017-03-21 22:53:43]

https://codereview.chromium.org/2756113002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2756113002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:210:
name_for_methods = property_['name']
On 2017/03/21 at 04:56:47, alancutter wrote:
> It's weird to call this name_for_methods, it should just be called name since
it's used for more than just methods.

Oops, that was meant to read "name_for_methods = property_['name_for_methods']".
Yeah unfortunately name_for_methods is shared with other generators, and "name"
is reserved for the name of the property.

[shend, 2017-03-21 22:53:48]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 22:54:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 23:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:15:25]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[shend, 2017-03-22 00:27:48]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-22 00:27:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2756113002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-22 00:28:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 02:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 02:30:02]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[shend, 2017-03-22 02:52:29]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-03-22 02:53:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 03:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:17:34]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[shend, 2017-03-22 03:56:00]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 03:56:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 04:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 04:52:29]

Dry run: This issue passed the CQ dry run.

[shend, 2017-03-22 04:56:20]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-03-22 04:56:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 05:10:56]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490158580765180,
"parent_rev": "a0f637af5fb75e1fbd58e4c4c03807c3e77fa213", "commit_rev":
"a6bfb94ddcb95eef883d62b3d65de8e13192e90c"}

[commit-bot: I haz the power, 2017-03-22 05:12:21]

Description was changed from

==========
Move naming related code in make_computed_style_base to name_utilities.

Currently make_computed_style_base is sprinkled with a lot of code
related to variable names and method names. These are common pieces of
logic that can be reused by other generators as well.

This patch tidies up make_computed_style_base by moving naming logic
to name_utilities.py.

BUG=628043
==========

to

==========
Move naming related code in make_computed_style_base to name_utilities.

Currently make_computed_style_base is sprinkled with a lot of code
related to variable names and method names. These are common pieces of
logic that can be reused by other generators as well.

This patch tidies up make_computed_style_base by moving naming logic
to name_utilities.py.

BUG=628043

Review-Url: https://codereview.chromium.org/2756113002
Cr-Commit-Position: refs/heads/master@{#458635}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6bfb94ddcb95eef883d62b3d65d...
==========

[commit-bot: I haz the power, 2017-03-22 05:12:22]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a6bfb94ddcb95eef883d62b3d65d...