Use CSSProperties.json5 format for nonproperties as well.

third_party/WebKit/Source/build/scripts/make_computed_style_base.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import math
 import sys
 
 import json5_generator
 import template_expander
 import make_style_builder
 
 from name_utilities import camel_case, lower_first, upper_first_letter, enum_for_css_keyword
 
 
 # Temporary hard-coded list of fields that are not CSS properties.
-# Ideally these would be specified in a .in or .json5 file.
-NONPROPERTY_FIELDS = set([
+# Ideally these would be specified in a .json5 file.
+NONPROPERTY_FIELDS = [
     # Style can not be shared.
-    'unique',
+    {'name': 'unique', 'field_template': 'monotonic_flag'},

[meade_UTC10, 2017/03/15 06:24:54]

Can you please add something to the CL description of what this list of dicts is
doing?

[shend, 2017/03/16 02:08:01]

Done.

     # Whether this style is affected by these pseudo-classes.
-    'affectedByFocus',
-    'affectedByHover',
-    'affectedByActive',
-    'affectedByDrag',
+    {'name': 'affectedByFocus', 'field_template': 'monotonic_flag'},
+    {'name': 'affectedByHover', 'field_template': 'monotonic_flag'},
+    {'name': 'affectedByActive', 'field_template': 'monotonic_flag'},
+    {'name': 'affectedByDrag', 'field_template': 'monotonic_flag'},
     # A non-inherited property references a variable or @apply is used
-    'hasVariableReferenceFromNonInheritedProperty',
+    {'name': 'hasVariableReferenceFromNonInheritedProperty', 'field_template': 'monotonic_flag'},
     # Explicitly inherits a non-inherited property
-    'hasExplicitlyInheritedProperties',
-])
+    {'name': 'hasExplicitlyInheritedProperties', 'field_template': 'monotonic_flag'}
+]
 
 
 class Field(object):
     """
     The generated ComputedStyle object is made up of a series of Fields.
     Each Field has a name, size, type, etc, and a bunch of attributes to
     determine which methods it will be used in.
 
     A Field also has enough information to use any storage type in C++, such as
     regular member variables, or more complex storage like vectors or hashmaps.
@@ skipping 152 matching lines @@
         field_template='flag',
         size=1,
         default_value='true',
         getter_method_name=field_name_suffix_lower,
         setter_method_name='set' + field_name_suffix_upper,
         initial_method_name='initial' + field_name_suffix_upper,
         resetter_method_name='reset' + field_name_suffix_upper,
     )
 
 
-def _create_nonproperty_field(field_name):
+def _create_nonproperty_field(property_):
     """
-    Create a nonproperty field from its name and return the Field object.
+    Create a nonproperty field from a property dict and return the Field object.

[meade_UTC10, 2017/03/15 06:24:54]

What's a property dict? Need a comment or rewording to make it clearer that
you're referring to the contents of NONPROPERTY_FIELDS.

[shend, 2017/03/16 02:08:01]

Done

     """
-    member_name = 'm_' + field_name
-    field_name_upper = upper_first_letter(field_name)
+    # TODO(shend): Make this work for nonflags
+    assert property_['field_template'] in ('flag', 'monotonic_flag'), \
+        "Nonproperties with arbitrary templates are not yet supported"
+    member_name = 'm_' + property_['name']
+    field_name_upper = upper_first_letter(property_['name'])
 
     return Field(
         'nonproperty',
         name=member_name,
-        property_name=field_name,
+        property_name=property_['name'],
         type_name='bool',
-        field_template='monotonic_flag',
+        field_template=property_['field_template'],
         size=1,
         default_value='false',
-        getter_method_name=field_name,
+        getter_method_name=property_['name'],
         setter_method_name='set' + field_name_upper,
         initial_method_name='initial' + field_name_upper,
         resetter_method_name='reset' + field_name_upper,
     )
 
 
 def _create_fields(properties):
     """
     Create ComputedStyle fields from CSS properties and return a list of Field objects.
     """
     fields = []
     for property_ in properties:
         # Only generate properties that have a field template
         if property_['field_template'] is not None:
             # If the property is independent, add the single-bit sized isInherited flag
             # to the list of Fields as well.
             if property_['independent']:
                 fields.append(_create_inherited_flag_field(property_))
 
             fields.append(_create_property_field(property_))
 
-    for field_name in NONPROPERTY_FIELDS:
-        fields.append(_create_nonproperty_field(field_name))
+    # TODO(shend): Merge NONPROPERTY_FIELDS with property_values so that properties and
+    # nonproperties can be treated uniformly.
+    for property_ in NONPROPERTY_FIELDS:
+        fields.append(_create_nonproperty_field(property_))
 
     return fields
 
 
 def _pack_fields(fields):
     """
     Group a list of fields into buckets to minimise padding.
     Returns a list of buckets, where each bucket is a list of Field objects.
     """
     # Since fields cannot cross word boundaries, in order to minimize
@@ skipping 118 matching lines @@
                     'mapping': [('k' + camel_case(k), enum_for_css_keyword(k)) for k in property_['keywords']],
                 }
 
         return {
             'include_paths': self._include_paths,
             'mappings': mappings,
         }
 
 if __name__ == '__main__':
     json5_generator.Maker(ComputedStyleBaseWriter).main()