Add support for flattening in GeometryMapper.

Add support for flattening in GeometryMapper.

Previously we assumed all matrices were preserve-3d, except flattening at the end.
This worked because we never used GeometryMapper in situations that have any 3D.

In adding tests, fixed what seems to be a bug in LayoutBox::mapToVisualRectInAncestor
space, in which it would skip flattening if either the local style or container
style was preseve-3d. The correct behavior is just container.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2744743003
Cr-Commit-Position: refs/heads/master@{#456281}
Committed: https://chromium.googlesource.com/chromium/src/+/60792c5afb8cb1eb84db0a874c95286e529eb850

[chrishtr, 2017-03-10 03:48:55]

Description was changed from

==========
none

BUG=
==========

to

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-10 03:49:04]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 03:49:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-10 05:08:05]

Description was changed from

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add support for flattening in GeometryMapper.

Previously we assumed all matrices were preserve-3d, except flattening at the
end.
This worked because we never used GeometryMapper in situations that have any 3D.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-03-10 05:14:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 05:14:35]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-03-10 05:37:08]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 05:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 07:10:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 07:10:06]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-03-10 23:23:45]

Description was changed from

==========
Add support for flattening in GeometryMapper.

Previously we assumed all matrices were preserve-3d, except flattening at the
end.
This worked because we never used GeometryMapper in situations that have any 3D.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add support for flattening in GeometryMapper.

Previously we assumed all matrices were preserve-3d, except flattening at the
end.
This worked because we never used GeometryMapper in situations that have any 3D.

In adding tests, fixed what seems to be a bug in
LayoutBox::mapToVisualRectInAncestor space, in which it would skip flattening if
either the local style or container style was preseve-3d. The
correct behavior is just container.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-10 23:29:40]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-03-10 23:29:52]

chrishtr@chromium.org changed reviewers:
+ trchen@chromium.org

[chrishtr, 2017-03-10 23:29:54]

https://codereview.chromium.org/2744743003/diff/90001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2744743003/diff/90001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2404: bool preserve3D =
container->style()->preserves3D();
Tested in VisualRectMappingTest.

https://codereview.chromium.org/2744743003/diff/90001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutInline.cpp (right):

https://codereview.chromium.org/2744743003/diff/90001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutInline.cpp:1214: bool preserve3D =
container->style()->preserves3D();
I'm not sure that this code has any effect at all, since transforms
can't be put on inlines. Wen I added support last week for 3D to
this method, I cargo culted from mapLocalToAncestor, but now I think
perhaps that method was simply wrong.

https://codereview.chromium.org/2744743003/diff/90001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2744743003/diff/90001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1308: bool preserve3D =
parent->style()->preserves3D() && !parent->isText();
Ditto here about whether this code has any use - is it for SVG children maybe?

https://codereview.chromium.org/2744743003/diff/90001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp (right):

https://codereview.chromium.org/2744743003/diff/90001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp:725: //
checkVisualRect(*target, *span, rect, LayoutRect(-200, -100, 33, 44));
Property trees are off by 200px.

[commit-bot: I haz the power, 2017-03-10 23:30:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-10 23:30:15]

Description was changed from

==========
Add support for flattening in GeometryMapper.

Previously we assumed all matrices were preserve-3d, except flattening at the
end.
This worked because we never used GeometryMapper in situations that have any 3D.

In adding tests, fixed what seems to be a bug in
LayoutBox::mapToVisualRectInAncestor space, in which it would skip flattening if
either the local style or container style was preseve-3d. The
correct behavior is just container.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add support for flattening in GeometryMapper.

Previously we assumed all matrices were preserve-3d, except flattening at the
end.
This worked because we never used GeometryMapper in situations that have any 3D.

In adding tests, fixed what seems to be a bug in
LayoutBox::mapToVisualRectInAncestor
space, in which it would skip flattening if either the local style or container
style was preseve-3d. The correct behavior is just container.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-11 00:03:57]

Updated to adjust some more tests.

[chrishtr, 2017-03-11 00:04:08]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 00:04:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[trchen, 2017-03-11 02:07:48]

lgtm.

The changes in Layout*.cpp looks scary, but I believe they in fact fix bugs, so
their result will be consistent with GeometryMapper?

[chrishtr, 2017-03-11 02:38:28]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-03-11 02:38:30]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:38:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-11 02:38:58]

On 2017/03/11 at 02:07:48, trchen wrote:
> lgtm.
> 
> The changes in Layout*.cpp looks scary, but I believe they in fact fix bugs,
so their result will be consistent with GeometryMapper?

Yes, that's why the change. Also, they are less scary when you realize I added
the code just a week ago.

[chrishtr, 2017-03-11 17:25:56]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-03-11 17:25:58]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-11 17:26:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 17:46:37]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1489253158997380,
"parent_rev": "4dc3db2b7fbdc48b6a3f052d725d85b5355d8cd2", "commit_rev":
"60792c5afb8cb1eb84db0a874c95286e529eb850"}

[commit-bot: I haz the power, 2017-03-11 17:48:03]

Description was changed from

==========
Add support for flattening in GeometryMapper.

Previously we assumed all matrices were preserve-3d, except flattening at the
end.
This worked because we never used GeometryMapper in situations that have any 3D.

In adding tests, fixed what seems to be a bug in
LayoutBox::mapToVisualRectInAncestor
space, in which it would skip flattening if either the local style or container
style was preseve-3d. The correct behavior is just container.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add support for flattening in GeometryMapper.

Previously we assumed all matrices were preserve-3d, except flattening at the
end.
This worked because we never used GeometryMapper in situations that have any 3D.

In adding tests, fixed what seems to be a bug in
LayoutBox::mapToVisualRectInAncestor
space, in which it would skip flattening if either the local style or container
style was preseve-3d. The correct behavior is just container.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2744743003
Cr-Commit-Position: refs/heads/master@{#456281}
Committed:
https://chromium.googlesource.com/chromium/src/+/60792c5afb8cb1eb84db0a874c95...
==========

[commit-bot: I haz the power, 2017-03-11 17:48:05]

Committed patchset #10 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/60792c5afb8cb1eb84db0a874c95...

[yoichio, 2017-03-13 07:44:23]

A revert of this CL (patchset #10 id:170001) has been created in
https://codereview.chromium.org/2749493003/ by yoichio@chromium.org.

The reason for reverting is: 1 test failed on Windows 7
VisualRectMappingTest.ShouldAccountForPreserve3dNested 
:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%....