Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp

Issue 2744743003: Add support for flattening in GeometryMapper. (Closed)
Patch Set: none Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
index 6258d642b44163697b80df40d37b24c93ed689c8..55f018cd203b269f739b2cfb1773f64fbb530436 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
@@ -373,6 +373,14 @@ const TransformationMatrix& GeometryMapper::localToAncestorMatrixInternal(
it++) {
TransformationMatrix localTransformMatrix = (*it)->matrix();
localTransformMatrix.applyTransformOrigin((*it)->origin());
+
+ // Flattening Lemma: flatten(A * flatten(B)) = flatten(flatten(A) * B).
+ // goo.gl/DNKyOc. Thus we can flatten transformMatrix rather than
+ // localTransformMatrix, because GeometryMapper only supports transforms
+ // into a flattened destination space.
+ if ((*it)->flattensInheritedTransform())
+ transformMatrix.flattenTo2d();
+
transformMatrix = transformMatrix * localTransformMatrix;
(*it)->getTransformCache().setCachedTransform(ancestorTransformNode,
transformMatrix);

Powered by Google App Engine
This is Rietveld 408576698