Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h

Issue 2744743003: Add support for flattening in GeometryMapper. (Closed)
Patch Set: none Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h
index c5a8ec363590b631f85f1104088fa28416094cbc..0b414c5ee96a738ccc322bd220c1322f5fc9e226 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h
@@ -113,6 +113,10 @@ class PLATFORM_EXPORT GeometryMapper {
// Returns the matrix used in |LocalToAncestorRect|. DCHECK fails iff
// |localTransformNode| is not equal to or a descendant of
// |ancestorTransformNode|.
+ // This matrix may not be flattened. Since GeometryMapper only supports
+ // flattened ancestor spaces, the returned matrix must be flattened to have
+ // the correct semantics (calling mapRect() on it implicitly applies
+ // flattening to the input; flattenTo2d() does it explicitly to tme matrix).
const TransformationMatrix& localToAncestorMatrix(
const TransformPaintPropertyNode* localTransformNode,
const TransformPaintPropertyNode* ancestorTransformNode);

Powered by Google App Engine
This is Rietveld 408576698