[ia32] Add some SSE2, SSE4 instructions and AVX version for SIMD

[ia32] Add some SSE2, SSE4 instructions and AVX version for SIMD

Add instructions in following format:
instr(xmm, xmm/mem)
vinstr(xmm, xmm, xmm/mem)

BUG=

Review-Url: https://codereview.chromium.org/2744643004
Cr-Commit-Position: refs/heads/master@{#43760}
Committed: https://chromium.googlesource.com/v8/v8/+/3800ba6cc7b083c720235770eb29afc04da31ae3

[Jing, 2017-03-10 13:51:12]

jing.bao@intel.com changed reviewers:
+ bbudge@chromium.org, bmeurer@chromium.org

[bbudge, 2017-03-10 19:56:15]

Overall, this looks good. Just a few comments.

https://codereview.chromium.org/2744643004/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (left):

https://codereview.chromium.org/2744643004/diff/1/src/ia32/assembler-ia32.h#o...
src/ia32/assembler-ia32.h:1030: void pcmpeqd(XMMRegister dst, XMMRegister src);
Why isn't this added to the SSE2 list instead? It seems like an older
instruction (not SSE4).

https://codereview.chromium.org/2744643004/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):

https://codereview.chromium.org/2744643004/diff/1/src/ia32/assembler-ia32.h#n...
src/ia32/assembler-ia32.h:1032: void punpckhdq(XMMRegister dst, XMMRegister
src);
Could you add these to the SSE/AVX list too?

[Jing, 2017-03-13 03:23:28]

https://codereview.chromium.org/2744643004/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (left):

https://codereview.chromium.org/2744643004/diff/1/src/ia32/assembler-ia32.h#o...
src/ia32/assembler-ia32.h:1030: void pcmpeqd(XMMRegister dst, XMMRegister src);
On 2017/03/10 19:56:15, bbudge wrote:
> Why isn't this added to the SSE2 list instead? It seems like an older
> instruction (not SSE4).

It is in the SSE2_INSTRUCTION_LIST (see sse-instr.h)

https://codereview.chromium.org/2744643004/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):

https://codereview.chromium.org/2744643004/diff/1/src/ia32/assembler-ia32.h#n...
src/ia32/assembler-ia32.h:1032: void punpckhdq(XMMRegister dst, XMMRegister
src);
On 2017/03/10 19:56:15, bbudge wrote:
> Could you add these to the SSE/AVX list too?

Done.

[Benedikt Meurer, 2017-03-13 08:19:28]

Very nice. LGTM!

[Jing, 2017-03-14 01:37:28]

The CQ bit was checked by jing.bao@intel.com

[commit-bot: I haz the power, 2017-03-14 01:37:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:00:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489455448196150,
"parent_rev": "118c376fcbe483b155eec26f8d9192f8cb4b4721", "commit_rev":
"3800ba6cc7b083c720235770eb29afc04da31ae3"}

[commit-bot: I haz the power, 2017-03-14 02:00:20]

Description was changed from

==========
[ia32] Add some SSE2, SSE4 instructions and AVX version for SIMD

Add instructions in following format:
instr(xmm, xmm/mem)
vinstr(xmm, xmm, xmm/mem)

BUG=
==========

to

==========
[ia32] Add some SSE2, SSE4 instructions and AVX version for SIMD

Add instructions in following format:
instr(xmm, xmm/mem)
vinstr(xmm, xmm, xmm/mem)

BUG=

Review-Url: https://codereview.chromium.org/2744643004
Cr-Commit-Position: refs/heads/master@{#43760}
Committed:
https://chromium.googlesource.com/v8/v8/+/3800ba6cc7b083c720235770eb29afc04da...
==========

[commit-bot: I haz the power, 2017-03-14 02:00:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3800ba6cc7b083c720235770eb29afc04da...