Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2744553002: [debugger] do not enable liveedit by default. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] do not enable liveedit by default. And a drive-by clean up of unused flag. R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2744553002 Cr-Commit-Position: refs/heads/master@{#43692} Committed: https://chromium.googlesource.com/v8/v8/+/43095c8c6f0f6fd3d578630dde3433c50314ad84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/d8.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-interface.h View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
3 years, 9 months ago (2017-03-09 05:50:58 UTC) #1
jgruber
lgtm
3 years, 9 months ago (2017-03-09 07:43:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744553002/1
3 years, 9 months ago (2017-03-09 07:45:43 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 12:29:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/43095c8c6f0f6fd3d578630dde3433c5031...

Powered by Google App Engine
This is Rietveld 408576698