Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: src/d8.cc

Issue 2744553002: [debugger] do not enable liveedit by default. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <errno.h> 5 #include <errno.h>
6 #include <stdlib.h> 6 #include <stdlib.h>
7 #include <string.h> 7 #include <string.h>
8 #include <sys/stat.h> 8 #include <sys/stat.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 2012 matching lines...) Expand 10 before | Expand all | Expand 10 after
2023 2023
2024 Local<Value> function = 2024 Local<Value> function =
2025 FunctionTemplate::New(isolate_, SendInspectorMessage) 2025 FunctionTemplate::New(isolate_, SendInspectorMessage)
2026 ->GetFunction(context) 2026 ->GetFunction(context)
2027 .ToLocalChecked(); 2027 .ToLocalChecked();
2028 Local<String> function_name = 2028 Local<String> function_name =
2029 String::NewFromUtf8(isolate_, "send", NewStringType::kNormal) 2029 String::NewFromUtf8(isolate_, "send", NewStringType::kNormal)
2030 .ToLocalChecked(); 2030 .ToLocalChecked();
2031 CHECK(context->Global()->Set(context, function_name, function).FromJust()); 2031 CHECK(context->Global()->Set(context, function_name, function).FromJust());
2032 2032
2033 v8::debug::SetLiveEditEnabled(isolate_, true);
2034
2033 context_.Reset(isolate_, context); 2035 context_.Reset(isolate_, context);
2034 } 2036 }
2035 2037
2036 private: 2038 private:
2037 static v8_inspector::V8InspectorSession* GetSession(Local<Context> context) { 2039 static v8_inspector::V8InspectorSession* GetSession(Local<Context> context) {
2038 InspectorClient* inspector_client = static_cast<InspectorClient*>( 2040 InspectorClient* inspector_client = static_cast<InspectorClient*>(
2039 context->GetAlignedPointerFromEmbedderData(kInspectorClientIndex)); 2041 context->GetAlignedPointerFromEmbedderData(kInspectorClientIndex));
2040 return inspector_client->session_.get(); 2042 return inspector_client->session_.get();
2041 } 2043 }
2042 2044
(...skipping 990 matching lines...) Expand 10 before | Expand all | Expand 10 after
3033 } 3035 }
3034 3036
3035 } // namespace v8 3037 } // namespace v8
3036 3038
3037 3039
3038 #ifndef GOOGLE3 3040 #ifndef GOOGLE3
3039 int main(int argc, char* argv[]) { 3041 int main(int argc, char* argv[]) {
3040 return v8::Shell::Main(argc, argv); 3042 return v8::Shell::Main(argc, argv);
3041 } 3043 }
3042 #endif 3044 #endif
OLDNEW
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698