Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: src/debug/debug.cc

Issue 2744553002: [debugger] do not enable liveedit by default. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/d8.cc ('k') | src/debug/debug-interface.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/arguments.h" 10 #include "src/arguments.h"
(...skipping 24 matching lines...) Expand all
35 #include "include/v8-debug.h" 35 #include "include/v8-debug.h"
36 36
37 namespace v8 { 37 namespace v8 {
38 namespace internal { 38 namespace internal {
39 39
40 Debug::Debug(Isolate* isolate) 40 Debug::Debug(Isolate* isolate)
41 : debug_context_(Handle<Context>()), 41 : debug_context_(Handle<Context>()),
42 is_active_(false), 42 is_active_(false),
43 hook_on_function_call_(false), 43 hook_on_function_call_(false),
44 is_suppressed_(false), 44 is_suppressed_(false),
45 live_edit_enabled_(true), // TODO(yangguo): set to false by default. 45 live_edit_enabled_(false),
46 break_disabled_(false), 46 break_disabled_(false),
47 break_points_active_(true), 47 break_points_active_(true),
48 break_on_exception_(false), 48 break_on_exception_(false),
49 break_on_uncaught_exception_(false), 49 break_on_uncaught_exception_(false),
50 side_effect_check_failed_(false), 50 side_effect_check_failed_(false),
51 debug_info_list_(NULL), 51 debug_info_list_(NULL),
52 feature_tracker_(isolate), 52 feature_tracker_(isolate),
53 isolate_(isolate) { 53 isolate_(isolate) {
54 ThreadInit(); 54 ThreadInit();
55 } 55 }
(...skipping 2396 matching lines...) Expand 10 before | Expand all | Expand 10 after
2452 isolate_->Throw(*isolate_->factory()->NewEvalError( 2452 isolate_->Throw(*isolate_->factory()->NewEvalError(
2453 MessageTemplate::kNoSideEffectDebugEvaluate)); 2453 MessageTemplate::kNoSideEffectDebugEvaluate));
2454 } 2454 }
2455 isolate_->set_needs_side_effect_check(old_needs_side_effect_check_); 2455 isolate_->set_needs_side_effect_check(old_needs_side_effect_check_);
2456 isolate_->debug()->UpdateHookOnFunctionCall(); 2456 isolate_->debug()->UpdateHookOnFunctionCall();
2457 isolate_->debug()->side_effect_check_failed_ = false; 2457 isolate_->debug()->side_effect_check_failed_ = false;
2458 } 2458 }
2459 2459
2460 } // namespace internal 2460 } // namespace internal
2461 } // namespace v8 2461 } // namespace v8
OLDNEW
« no previous file with comments | « src/d8.cc ('k') | src/debug/debug-interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698