Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 274383002: events: Remove ability to terminate a nested message-loop from the event-source. (Closed)

Created:
6 years, 7 months ago by sadrul
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, ben+ash_chromium.org, tdresser+watch_chromium.org
Visibility:
Public.

Description

events: Remove ability to terminate a nested message-loop from the event-source. Terminating a message-loop directly using MessageLoop::QuitNow() can terminate the message-loop at the incorrect depth. So remove the ability of the event-source to terminate the message-loop, and require the relevant code that initiated the nested message-loop to be responsible for terminating it. BUG=372208 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270483

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tot-merge #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -32 lines) Patch
M ash/accelerators/accelerator_dispatcher_linux.cc View 1 chunk +1 line, -1 line 1 comment Download
M ui/events/platform/platform_event_dispatcher.h View 2 chunks +5 lines, -9 lines 0 comments Download
M ui/events/platform/platform_event_source.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/platform/platform_event_source.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M ui/events/platform/platform_event_source_unittest.cc View 6 chunks +30 lines, -6 lines 0 comments Download
M ui/events/platform/x11/x11_event_source.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/platform/x11/x11_event_source.cc View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
https://codereview.chromium.org/274383002/diff/40001/ash/accelerators/accelerator_dispatcher_linux.cc File ash/accelerators/accelerator_dispatcher_linux.cc (right): https://codereview.chromium.org/274383002/diff/40001/ash/accelerators/accelerator_dispatcher_linux.cc#newcode72 ash/accelerators/accelerator_dispatcher_linux.cc:72: return ui::POST_DISPATCH_NONE; MenuClosedForPossibleAccelerator() (line 66) calls MenuController::CancelAll(), which in ...
6 years, 7 months ago (2014-05-14 17:46:33 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-14 19:09:39 UTC) #2
sadrul
6 years, 7 months ago (2014-05-14 21:59:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r270483 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698