Fix an issue in fullscreen detector when context is destroyed

Fix an issue in fullscreen detector when context is destroyed

There's a race condition causing the WebMediaPlayer to be destroyed
before MediaCustomControlsFullscreenDetector dispatches the final
change. This CL fixes the issue.

BUG=698034
Review-Url: https://codereview.chromium.org/2743573003
Cr-Commit-Position: refs/heads/master@{#456160}
Committed: https://chromium.googlesource.com/chromium/src/+/ac5c34a5e762fd095bf129de24512100be09872a

[Zhiqiang Zhang (Slow), 2017-03-09 22:35:42]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-03-10 11:37:55]

lgtm

You might want to re-enable the test that was disabled.

https://codereview.chromium.org/2743573003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/2743573003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:362: void
contextDestroyed(ExecutionContext*);
override?

[Zhiqiang Zhang (Slow), 2017-03-10 14:57:03]

On 2017/03/10 at 11:37:55, mlamouri wrote:
> You might want to re-enable the test that was disabled.

Done

[Zhiqiang Zhang (Slow), 2017-03-10 14:57:13]

zqzhang@chromium.org changed reviewers:
+ japhet@chromium.org

[Zhiqiang Zhang (Slow), 2017-03-10 14:57:14]

https://codereview.chromium.org/2743573003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/2743573003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:362: void
contextDestroyed(ExecutionContext*);
On 2017/03/10 at 11:37:55, mlamouri wrote:
> override?

Done.

[Zhiqiang Zhang (Slow), 2017-03-10 14:57:32]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 14:57:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 16:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 16:33:40]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-03-10 19:18:30]

lgtm

[Zhiqiang Zhang (Slow), 2017-03-10 21:01:22]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2017-03-10 21:01:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2743573003/#ps20001
(title: "addressed nits")

[commit-bot: I haz the power, 2017-03-10 21:02:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 21:07:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489179682788050,
"parent_rev": "d5fc002027195691680b127e58458d1b2b86d5a1", "commit_rev":
"ac5c34a5e762fd095bf129de24512100be09872a"}

[commit-bot: I haz the power, 2017-03-10 21:08:18]

Description was changed from

==========
Fix an issue in fullscreen detector when context is destroyed

There's a race condition causing the WebMediaPlayer to be destroyed
before MediaCustomControlsFullscreenDetector dispatches the final
change. This CL fixes the issue.

BUG=698034
==========

to

==========
Fix an issue in fullscreen detector when context is destroyed

There's a race condition causing the WebMediaPlayer to be destroyed
before MediaCustomControlsFullscreenDetector dispatches the final
change. This CL fixes the issue.

BUG=698034

Review-Url: https://codereview.chromium.org/2743573003
Cr-Commit-Position: refs/heads/master@{#456160}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac5c34a5e762fd095bf129de2451...
==========

[commit-bot: I haz the power, 2017-03-10 21:08:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ac5c34a5e762fd095bf129de2451...