third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp - Issue 2743573003: Fix an issue in fullscreen detector when context is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

Issue 2743573003: Fix an issue in fullscreen detector when context is destroyed (Closed)

Patch Set: addressed nits Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | third_party/WebKit/Source/core/html/HTMLVideoElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

index 208cadb91527c2b0a9da237a601a6412f33adf5b..2d525dc9c88896bf2f6421657d4b35037d4b0716 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

@@ -129,9 +129,8 @@ TEST_F(HTMLMediaElementEventListenersTest,

EXPECT_EQ(controls(), video()->mediaControls());

}

-// crbug.com/700207

TEST_F(HTMLMediaElementEventListenersTest,

- DISABLED_FullscreenDetectorTimerCancelledOnContextDestroy) {

+ FullscreenDetectorTimerCancelledOnContextDestroy) {

EXPECT_EQ(video(), nullptr);

document().body()->setInnerHTML("<body><video></video</body>");

video()->setSrc("http://example.com");

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | third_party/WebKit/Source/core/html/HTMLVideoElement.h » ('j') | no next file with comments »