Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h

Issue 2743573003: Fix an issue in fullscreen detector when context is destroyed (Closed)
Patch Set: addressed nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h
diff --git a/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h b/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h
index 4d0f2154e7eaba969c94c05f9ac69ed1750d6ff6..316c74bea0d43c8a5f5370321da3e80f041c6ba5 100644
--- a/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h
+++ b/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h
@@ -6,7 +6,6 @@
#define MediaCustomControlsFullscreenDetector_h
#include "core/CoreExport.h"
-#include "core/dom/ContextLifecycleObserver.h"
#include "core/events/EventListener.h"
#include "platform/Timer.h"
@@ -17,9 +16,7 @@ class IntRect;
class TimerBase;
class CORE_EXPORT MediaCustomControlsFullscreenDetector final
- : public EventListener,
- public ContextLifecycleObserver {
- USING_GARBAGE_COLLECTED_MIXIN(MediaCustomControlsFullscreenDetector);
+ : public EventListener {
WTF_MAKE_NONCOPYABLE(MediaCustomControlsFullscreenDetector);
public:
@@ -28,8 +25,7 @@ class CORE_EXPORT MediaCustomControlsFullscreenDetector final
// EventListener implementation.
bool operator==(const EventListener&) const override;
- // ContextLifecycleObserver implemnetation.
- void contextDestroyed(ExecutionContext*);
+ void contextDestroyed();
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698