Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2743243005: Initialize PasswordReuseDetector on PasswordStore initialization on Mac. (Closed)

Created:
3 years, 9 months ago by dvadym
Modified:
3 years, 9 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize PasswordReuseDetector on PasswordStore initialization on Mac. BUG=668155 Review-Url: https://codereview.chromium.org/2743243005 Cr-Commit-Position: refs/heads/master@{#456744} Committed: https://chromium.googlesource.com/chromium/src/+/18b8670fe8e1dcbe4955cbb47682b653fddd9ecc

Patch Set 1 #

Patch Set 2 : test fixed #

Total comments: 2

Patch Set 3 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M chrome/browser/password_manager/password_store_proxy_mac.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M components/password_manager/core/browser/password_store.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 2 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dvadym
Hi Vasilii, Could you please review this CL? Regards, Vadym
3 years, 9 months ago (2017-03-14 14:37:15 UTC) #3
vasilii
lgtm https://codereview.chromium.org/2743243005/diff/20001/components/password_manager/core/browser/password_store_unittest.cc File components/password_manager/core/browser/password_store_unittest.cc (right): https://codereview.chromium.org/2743243005/diff/20001/components/password_manager/core/browser/password_store_unittest.cc#newcode855 components/password_manager/core/browser/password_store_unittest.cc:855: OSCryptMocker::SetUpWithSingleton(); Add a comment explaining the reason.
3 years, 9 months ago (2017-03-14 16:09:25 UTC) #4
dvadym
Thanks for review Vasilii! https://codereview.chromium.org/2743243005/diff/20001/components/password_manager/core/browser/password_store_unittest.cc File components/password_manager/core/browser/password_store_unittest.cc (right): https://codereview.chromium.org/2743243005/diff/20001/components/password_manager/core/browser/password_store_unittest.cc#newcode855 components/password_manager/core/browser/password_store_unittest.cc:855: OSCryptMocker::SetUpWithSingleton(); On 2017/03/14 16:09:25, vasilii ...
3 years, 9 months ago (2017-03-14 16:25:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743243005/40001
3 years, 9 months ago (2017-03-14 17:01:08 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 17:13:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/18b8670fe8e1dcbe4955cbb47682...

Powered by Google App Engine
This is Rietveld 408576698