Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 2743243005: Initialize PasswordReuseDetector on PasswordStore initialization on Mac. (Closed)
Patch Set: Added comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
index 700ed85778fc386c5c21bec088a81024272ea1b0..8cff9847c69698da6af7c2f1c7cd91fecb5cd7d5 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
@@ -110,16 +110,7 @@ class ManagePasswordsBubbleModelTest : public ::testing::Test {
password_manager::BuildPasswordStore<
content::BrowserContext,
testing::StrictMock<password_manager::MockPasswordStore>>);
-#if !defined(OS_MACOSX)
- // TODO(crbug.com/668155): Remove conditional compilation when
- // PasswordReuseDetector initialization will be implemented for Mac.
- // The call of FillAutofillableLogins is caused by a posted task for an
- // initialization of PasswordReuseDetector in the call of
- // BuildPasswordStore() in the previous code. There is no thread race since
- // unit tests run in one thread, and any post task will be executed after
- // finishing the current function.
EXPECT_CALL(*GetStore(), FillAutofillableLogins(_));
-#endif
}
void TearDown() override {

Powered by Google App Engine
This is Rietveld 408576698