Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/password_manager/core/browser/password_store.cc

Issue 2743243005: Initialize PasswordReuseDetector on PasswordStore initialization on Mac. (Closed)
Patch Set: Added comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc ('k') | components/password_manager/core/browser/password_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_store.cc
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc
index 4750796439f3f99509af04da3f89f1a8f7dcf81c..b9f7f2b66bb1390fa00a98c2ab2bdeff32f1ec08 100644
--- a/components/password_manager/core/browser/password_store.cc
+++ b/components/password_manager/core/browser/password_store.cc
@@ -705,12 +705,8 @@ void PasswordStore::InitOnBackgroundThread(
syncable_service_.reset(new PasswordSyncableService(this));
syncable_service_->InjectStartSyncFlare(flare);
reuse_detector_.reset(new PasswordReuseDetector);
-#if !defined(OS_MACOSX)
- // TODO(crbug.com/668155): For non-migrated keychain users it can lead to
- // hundreds of requests to unlock keychain.
GetAutofillableLoginsImpl(
base::MakeUnique<GetLoginsRequest>(reuse_detector_.get()));
-#endif
}
void PasswordStore::DestroyOnBackgroundThread() {
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc ('k') | components/password_manager/core/browser/password_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698