Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2742983003: MD Settings: fix attribute name typo to enhance a11y of JavaScript subpage button on content settin… (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix attribute name typo to enhance a11y of JavaScript subpage button on content settings page R=dschuyler@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2742983003 Cr-Commit-Position: refs/heads/master@{#456251} Committed: https://chromium.googlesource.com/chromium/src/+/2c5480e85b7f645bd2c08cfe5b6c24ffa22c1206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Beam
3 years, 9 months ago (2017-03-11 00:07:42 UTC) #2
dschuyler
lgtm
3 years, 9 months ago (2017-03-11 01:36:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742983003/1
3 years, 9 months ago (2017-03-11 01:43:55 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 01:50:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c5480e85b7f645bd2c08cfe5b6c...

Powered by Google App Engine
This is Rietveld 408576698