chrome/browser/resources/settings/site_settings_page/site_settings_page.html - Issue 2742983003: MD Settings: fix attribute name typo to enhance a11y of JavaScript subpage button on content settin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Issue 2742983003: MD Settings: fix attribute name typo to enhance a11y of JavaScript subpage button on content settin… (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

index a2f49dd9df30a12061956edeee0156fba9aec6e3..510bbaa01eb064b8a1a083f08599a8282e0014eb 100644

--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

@@ -121,7 +121,7 @@

<iron-icon icon="settings:input"></iron-icon>

$i18n{siteSettingsJavascript}

- <div class="secondary" is="javascriptSecondary">

+ <div class="secondary" id="javascriptSecondary">

[[defaultSettingLabel_(

default_.javascript,

'$i18nPolymer{siteSettingsAllowed}',

« no previous file with comments | « no previous file | no next file » | no next file with comments »