Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Issue 2742983003: MD Settings: fix attribute name typo to enhance a11y of JavaScript subpage button on content settin… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 2 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
4 <link rel="import" href="../icons.html"> 4 <link rel="import" href="../icons.html">
5 <link rel="import" href="../route.html"> 5 <link rel="import" href="../route.html">
6 <link rel="import" href="../settings_shared_css.html"> 6 <link rel="import" href="../settings_shared_css.html">
7 <link rel="import" href="../site_settings/constants.html"> 7 <link rel="import" href="../site_settings/constants.html">
8 <link rel="import" href="../site_settings/site_settings_behavior.html"> 8 <link rel="import" href="../site_settings/site_settings_behavior.html">
9 <link rel="import" href="../site_settings/site_settings_prefs_browser_proxy.html "> 9 <link rel="import" href="../site_settings/site_settings_prefs_browser_proxy.html ">
10 10
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 aria-label="$i18n{siteSettingsNotifications}" 114 aria-label="$i18n{siteSettingsNotifications}"
115 aria-describedby="notificationsSecondary"></button> 115 aria-describedby="notificationsSecondary"></button>
116 </div> 116 </div>
117 <div class="settings-box two-line" 117 <div class="settings-box two-line"
118 category$="[[ContentSettingsTypes.JAVASCRIPT]]" 118 category$="[[ContentSettingsTypes.JAVASCRIPT]]"
119 data-route="SITE_SETTINGS_JAVASCRIPT" on-tap="onTapNavigate_" 119 data-route="SITE_SETTINGS_JAVASCRIPT" on-tap="onTapNavigate_"
120 actionable> 120 actionable>
121 <iron-icon icon="settings:input"></iron-icon> 121 <iron-icon icon="settings:input"></iron-icon>
122 <div class="middle"> 122 <div class="middle">
123 $i18n{siteSettingsJavascript} 123 $i18n{siteSettingsJavascript}
124 <div class="secondary" is="javascriptSecondary"> 124 <div class="secondary" id="javascriptSecondary">
125 [[defaultSettingLabel_( 125 [[defaultSettingLabel_(
126 default_.javascript, 126 default_.javascript,
127 '$i18nPolymer{siteSettingsAllowed}', 127 '$i18nPolymer{siteSettingsAllowed}',
128 '$i18nPolymer{siteSettingsBlocked}')]] 128 '$i18nPolymer{siteSettingsBlocked}')]]
129 </div> 129 </div>
130 </div> 130 </div>
131 <button class="subpage-arrow" is="paper-icon-button-light" 131 <button class="subpage-arrow" is="paper-icon-button-light"
132 aria-label="$i18n{siteSettingsJavascript}" 132 aria-label="$i18n{siteSettingsJavascript}"
133 aria-describedby="javascriptSecondary"></button> 133 aria-describedby="javascriptSecondary"></button>
134 </div> 134 </div>
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 <div class="settings-box" data-route="SITE_SETTINGS_PROTECTED_CONTENT" 301 <div class="settings-box" data-route="SITE_SETTINGS_PROTECTED_CONTENT"
302 on-tap="onTapNavigate_" actionable> 302 on-tap="onTapNavigate_" actionable>
303 <iron-icon icon="settings:security"></iron-icon> 303 <iron-icon icon="settings:security"></iron-icon>
304 <div class="middle">$i18n{siteSettingsProtectedContent}</div> 304 <div class="middle">$i18n{siteSettingsProtectedContent}</div>
305 <button class="subpage-arrow" is="paper-icon-button-light" 305 <button class="subpage-arrow" is="paper-icon-button-light"
306 aria-label="$i18n{siteSettingsProtectedContent}"></button> 306 aria-label="$i18n{siteSettingsProtectedContent}"></button>
307 </div> 307 </div>
308 </template> 308 </template>
309 <script src="site_settings_page.js"></script> 309 <script src="site_settings_page.js"></script>
310 </dom-module> 310 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698