Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2742833004: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)

Created:
3 years, 9 months ago by Dmitry Titov
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix the Download Notifications for Offline Pages to indicate bytes loaded. This wires the UpdateProgress call from PrerenderingOffliner via DownloadUIAdapter to the DownloadNotifyingObserver. As a result, the Android notifications about ongoing Offline Page downloads start to be updated with a real byte count. BUG=698020 Review-Url: https://codereview.chromium.org/2736843002 Cr-Commit-Position: refs/heads/master@{#455486} (cherry picked from commit 0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3) Review-Url: https://codereview.chromium.org/2742833004 . Cr-Commit-Position: refs/branch-heads/3029@{#101} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5272c36578a4bca85626b8f27eeea4d790749383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -89 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc View 16 chunks +37 lines, -15 lines 0 comments Download
M chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_offliner.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/prerendering_offliner.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc View 19 chunks +43 lines, -18 lines 0 comments Download
M components/offline_pages/core/background/cleanup_task_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/offline_pages/core/background/offliner.h View 2 chunks +9 lines, -3 lines 0 comments Download
M components/offline_pages/core/background/offliner_stub.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/offline_pages/core/background/offliner_stub.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M components/offline_pages/core/background/pick_request_task_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator.h View 3 chunks +9 lines, -0 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator_unittest.cc View 5 chunks +21 lines, -0 lines 0 comments Download
M components/offline_pages/core/background/request_notifier.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/offline_pages/core/background/request_queue_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/offline_pages/core/downloads/download_notifying_observer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/offline_pages/core/downloads/download_notifying_observer.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M components/offline_pages/core/downloads/download_ui_adapter.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/offline_pages/core/downloads/download_ui_adapter.cc View 2 chunks +16 lines, -13 lines 0 comments Download
M components/offline_pages/core/downloads/download_ui_adapter_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Dmitry Titov
3 years, 9 months ago (2017-03-10 00:22:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5272c36578a4bca85626b8f27eeea4d790749383 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698