Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2742833004: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc
index d85f3cbfea17544a4d9dbb19c1d04f52b1e3b683..f13910e0ca7de04eb60a066c78ffc76d721675af 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc
@@ -36,14 +36,10 @@ PrerenderingOffliner::~PrerenderingOffliner() {}
void PrerenderingOffliner::OnNetworkProgress(const SavePageRequest& request,
int64_t bytes) {
- if (!pending_request_)
- return;
- DownloadUIAdapter* ui_adapter =
- DownloadUIAdapter::FromOfflinePageModel(offline_page_model_);
- if (!ui_adapter)
+ if (!pending_request_ || !progress_callback_)
return;
- ui_adapter->UpdateProgress(request.request_id(), bytes);
+ progress_callback_.Run(request, bytes);
}
void PrerenderingOffliner::OnLoadPageDone(
@@ -131,8 +127,10 @@ void PrerenderingOffliner::OnSavePageDone(
completion_callback_.Run(request, save_status);
}
-bool PrerenderingOffliner::LoadAndSave(const SavePageRequest& request,
- const CompletionCallback& callback) {
+bool PrerenderingOffliner::LoadAndSave(
+ const SavePageRequest& request,
+ const CompletionCallback& completion_callback,
+ const ProgressCallback& progress_callback) {
DCHECK(!pending_request_.get());
if (pending_request_) {
@@ -190,7 +188,8 @@ bool PrerenderingOffliner::LoadAndSave(const SavePageRequest& request,
// Track copy of pending request for callback handling.
pending_request_.reset(new SavePageRequest(request));
- completion_callback_ = callback;
+ completion_callback_ = completion_callback;
+ progress_callback_ = progress_callback;
// Kick off load page attempt.
bool accepted = GetOrCreateLoader()->LoadPage(

Powered by Google App Engine
This is Rietveld 408576698