Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: components/offline_pages/core/downloads/download_ui_adapter.h

Issue 2742833004: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/downloads/download_ui_adapter.h
diff --git a/components/offline_pages/core/downloads/download_ui_adapter.h b/components/offline_pages/core/downloads/download_ui_adapter.h
index 4fef8e1b5a54b8486f1fea6d5b3b64de21f9878c..2744f0b643826d72db24360edc43fb2e53821afd 100644
--- a/components/offline_pages/core/downloads/download_ui_adapter.h
+++ b/components/offline_pages/core/downloads/download_ui_adapter.h
@@ -103,7 +103,6 @@ class DownloadUIAdapter : public OfflinePageModel::Observer,
// via Observer or directly by the user (as in 'open').
void DeleteItem(const std::string& guid);
int64_t GetOfflineIdByGuid(const std::string& guid) const;
- void UpdateProgress(int64_t offline_id, int64_t bytes);
// OfflinePageModel::Observer
void OfflinePageModelLoaded(OfflinePageModel* model) override;
@@ -117,6 +116,8 @@ class DownloadUIAdapter : public OfflinePageModel::Observer,
void OnCompleted(const SavePageRequest& request,
RequestNotifier::BackgroundSavePageResult status) override;
void OnChanged(const SavePageRequest& request) override;
+ void OnNetworkProgress(const SavePageRequest& request,
+ int64_t received_bytes) override;
// For the DownloadUIAdapter::Delegate, to report the temporary hidden status
// change.

Powered by Google App Engine
This is Rietveld 408576698