Chromium Code Reviews
DescriptionReland of Make EventHandlerRegistry store Page instead of FrameHost (patchset #1 id:1 of https://codereview.chromium.org/2737863005/ )
Reason for revert:
Patch unrelated to test failure; trying to revert-revert
Original issue's description:
> Revert of Make EventHandlerRegistry store Page instead of FrameHost (patchset #1 id:1 of https://codereview.chromium.org/2736753003/ )
>
> Reason for revert:
> virtual/gpu-rasterization/images/cross-fade-background-size.html failed after this change.
>
> No idea why, perhaps it is too sensitive, or needs a concurrent rebaseline.
>
> Tracked in bug 699573
>
> Original issue's description:
> > Make EventHandlerRegistry store Page instead of FrameHost
> >
> > This is pre-work to move FrameHost::m_eventHandlerRegistry to Page. Also
> > renamed didMove{Into,OutOf}FrameHost to didMove{Into,OutOf}Page, which
> > now makes more sense.
> >
> > BUG=691794
> >
> > Review-Url: https://codereview.chromium.org/2736753003
> > Cr-Commit-Position: refs/heads/master@{#455379}
> > Committed: https://chromium.googlesource.com/chromium/src/+/5c4056a61c3d24b5df4ebdba406467b96ff68866
>
> TBR=joelhockey@chromium.org,sashab@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=691794
>
> Review-Url: https://codereview.chromium.org/2737863005
> Cr-Commit-Position: refs/heads/master@{#455462}
> Committed: https://chromium.googlesource.com/chromium/src/+/c5a5f183a349f0088685acc2a063f9b84e9ec237
TBR=joelhockey@chromium.org,petermayo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=691794
Review-Url: https://codereview.chromium.org/2742543002
Cr-Commit-Position: refs/heads/master@{#455575}
Committed: https://chromium.googlesource.com/chromium/src/+/6fe37909237df848564e70b749eac2a3a8e32b95
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||