Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2736753003: Make EventHandlerRegistry store Page instead of FrameHost (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EventHandlerRegistry store Page instead of FrameHost This is pre-work to move FrameHost::m_eventHandlerRegistry to Page. Also renamed didMove{Into,OutOf}FrameHost to didMove{Into,OutOf}Page, which now makes more sense. BUG=691794 Review-Url: https://codereview.chromium.org/2736753003 Cr-Commit-Position: refs/heads/master@{#455379} Committed: https://chromium.googlesource.com/chromium/src/+/5c4056a61c3d24b5df4ebdba406467b96ff68866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -29 lines) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.h View 5 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 8 chunks +14 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
sashab
3 years, 9 months ago (2017-03-07 05:25:08 UTC) #5
joelhockey
lgtm
3 years, 9 months ago (2017-03-07 05:43:22 UTC) #7
haraken
LGTM
3 years, 9 months ago (2017-03-07 06:30:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736753003/1
3 years, 9 months ago (2017-03-08 01:00:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5c4056a61c3d24b5df4ebdba406467b96ff68866
3 years, 9 months ago (2017-03-08 04:34:24 UTC) #15
Peter Mayo
On 2017/03/08 04:34:24, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 9 months ago (2017-03-08 16:00:07 UTC) #16
Peter Mayo
On 2017/03/08 16:00:07, Peter Mayo wrote: > On 2017/03/08 04:34:24, commit-bot: I haz the power ...
3 years, 9 months ago (2017-03-08 16:01:05 UTC) #17
Peter Mayo
3 years, 9 months ago (2017-03-08 16:04:49 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2737863005/ by petermayo@chromium.org.

The reason for reverting is:
virtual/gpu-rasterization/images/cross-fade-background-size.html failed after
this change.

No idea why, perhaps it is too sensitive, or needs a concurrent rebaseline.

Tracked in bug 699573.

Powered by Google App Engine
This is Rietveld 408576698