Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2737863005: Revert of Make EventHandlerRegistry store Page instead of FrameHost (Closed)

Created:
3 years, 9 months ago by Peter Mayo
Modified:
3 years, 9 months ago
Reviewers:
sashab, joelhockey
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make EventHandlerRegistry store Page instead of FrameHost (patchset #1 id:1 of https://codereview.chromium.org/2736753003/ ) Reason for revert: virtual/gpu-rasterization/images/cross-fade-background-size.html failed after this change. No idea why, perhaps it is too sensitive, or needs a concurrent rebaseline. Tracked in bug 699573 Original issue's description: > Make EventHandlerRegistry store Page instead of FrameHost > > This is pre-work to move FrameHost::m_eventHandlerRegistry to Page. Also > renamed didMove{Into,OutOf}FrameHost to didMove{Into,OutOf}Page, which > now makes more sense. > > BUG=691794 > > Review-Url: https://codereview.chromium.org/2736753003 > Cr-Commit-Position: refs/heads/master@{#455379} > Committed: https://chromium.googlesource.com/chromium/src/+/5c4056a61c3d24b5df4ebdba406467b96ff68866 TBR=joelhockey@chromium.org,sashab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691794 Review-Url: https://codereview.chromium.org/2737863005 Cr-Commit-Position: refs/heads/master@{#455462} Committed: https://chromium.googlesource.com/chromium/src/+/c5a5f183a349f0088685acc2a063f9b84e9ec237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.h View 5 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 8 chunks +17 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Mayo
Created Revert of Make EventHandlerRegistry store Page instead of FrameHost
3 years, 9 months ago (2017-03-08 16:04:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737863005/1
3 years, 9 months ago (2017-03-08 16:05:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c5a5f183a349f0088685acc2a063f9b84e9ec237
3 years, 9 months ago (2017-03-08 16:06:32 UTC) #6
haraken
I don't think the CL is related though.
3 years, 9 months ago (2017-03-08 17:30:58 UTC) #7
sashab
3 years, 9 months ago (2017-03-08 22:58:41 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2742543002/ by sashab@chromium.org.

The reason for reverting is: Patch unrelated to test failure; trying to
revert-revert.

Powered by Google App Engine
This is Rietveld 408576698