Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2742383006: Display: set color_depth and depth_per_component value based on kEnableHDROutput (Closed)

Created:
3 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 9 months ago
Reviewers:
hubbe, jbauman, nasko, ccameron
CC:
cc-bugs_chromium.org, chfremer+watch_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, Ian Vollick
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Display: set color_depth and depth_per_component value based on kEnableHDROutput This is also update the aura code creating the ScreenInfo to use the value reported by display::Display instead of hardcoding it as display::Display was doing the same thing. It is more consistent too as the Mac implementation was already doing this. This is also moving the kEnableHDROutput from ui/base/ to ui/display/ because ui/display/ can't depend on ui/base/ and it only moves the dependency of ui/compositor/ from ui/base/ to ui/display/. In the future, we should set the values on display::Display instead of hardcoding too values. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/c-b866DUg10/MxS1WTWfBgAJ BUG=701466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2742383006 Cr-Commit-Position: refs/heads/master@{#459288} Committed: https://chromium.googlesource.com/chromium/src/+/7c149655e1546c3bb4478f4dca931e5ad35d4073

Patch Set 1 #

Patch Set 2 : fix content_browsertests compile #

Patch Set 3 : blaH #

Patch Set 4 : rebase #

Patch Set 5 : fix more compile issues #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -25 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_unittest.cc View 1 2 3 4 5 2 chunks +40 lines, -2 lines 0 comments Download
M content/renderer/media/render_media_client.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/child_window_surface_win.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ui/display/display.cc View 1 2 3 4 5 3 chunks +10 lines, -3 lines 0 comments Download
M ui/display/display_switches.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/display/display_switches.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M ui/display/display_unittest.cc View 1 2 3 4 5 2 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 59 (43 generated)
mlamouri (slow - plz ping)
hubbe@ and ccameron@, PTAL :) nasko@, I will need an OWNERS look at the changes ...
3 years, 9 months ago (2017-03-14 21:16:47 UTC) #5
hubbe
lgtm
3 years, 9 months ago (2017-03-14 21:53:07 UTC) #15
ccameron
lgtm
3 years, 9 months ago (2017-03-14 23:15:22 UTC) #18
nasko
content/ rubberstamp LGTM
3 years, 9 months ago (2017-03-14 23:41:33 UTC) #19
mlamouri (slow - plz ping)
+jbauman@ for gpu/ changes
3 years, 9 months ago (2017-03-15 00:27:52 UTC) #28
jbauman
lgtm
3 years, 9 months ago (2017-03-15 00:30:41 UTC) #29
hubbe
FYI: renamed kEnableHDROutput to just kEnableHDR, so this CL will require a small merge.
3 years, 9 months ago (2017-03-15 20:59:26 UTC) #32
mlamouri (slow - plz ping)
On 2017/03/15 at 20:59:26, hubbe wrote: > FYI: renamed kEnableHDROutput to just kEnableHDR, so this ...
3 years, 9 months ago (2017-03-16 11:49:20 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742383006/100001
3 years, 9 months ago (2017-03-23 19:41:25 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/373601) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 9 months ago (2017-03-23 20:10:25 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742383006/120001
3 years, 9 months ago (2017-03-23 20:47:27 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742383006/120001
3 years, 9 months ago (2017-03-23 21:38:29 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/8027)
3 years, 9 months ago (2017-03-23 22:43:38 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742383006/120001
3 years, 9 months ago (2017-03-23 23:32:47 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742383006/120001
3 years, 9 months ago (2017-03-23 23:51:31 UTC) #56
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 00:01:06 UTC) #59
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/7c149655e1546c3bb4478f4dca93...

Powered by Google App Engine
This is Rietveld 408576698