Fix the positioning of the TryChromeDialog when the taskbar is hidden.

Fix the positioning of the TryChromeDialog when the taskbar is hidden.

In cases of multi-monitor, MonitorFromWindow may return a secondary
monitor depending on the orientation of the monitors, so simply position
the window based on the work area of the primary monitor.

Also fixes a bug in the panic fallback that was improperly increasing
the size of the dialog.

BUG=700857
R=huangs@chromium.org

Review-Url: https://codereview.chromium.org/2742343002
Cr-Commit-Position: refs/heads/master@{#456664}
Committed: https://chromium.googlesource.com/chromium/src/+/b2dd7ef5625c8ab415c1257d53b7a721dfffc344

[grt (UTC plus 2), 2017-03-13 12:06:27]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[grt (UTC plus 2), 2017-03-13 12:06:32]

PTAL, thanks.

[commit-bot: I haz the power, 2017-03-13 12:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 12:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 12:43:57]

Dry run: This issue passed the CQ dry run.

[huangs, 2017-03-13 15:29:28]

LGTM with NITS.  It seems this also works if user has taskbar dragge to screen
left/right/top?

https://codereview.chromium.org/2742343002/diff/1/chrome/browser/first_run/tr...
File chrome/browser/first_run/try_chrome_dialog_view.h (right):

https://codereview.chromium.org/2742343002/diff/1/chrome/browser/first_run/tr...
chrome/browser/first_run/try_chrome_dialog_view.h:16: namespace gfx {
Probably should include; please see below.

https://codereview.chromium.org/2742343002/diff/1/chrome/browser/first_run/tr...
chrome/browser/first_run/try_chrome_dialog_view.h:98: gfx::Rect
ComputeWindowPosition(gfx::Size size, bool is_RTL);
gfx::Rect and gfx::Size are returned / passed by value. This works probably
because the .h file got included somewhere along the line; and predeclaring them
is redundant.  Perhaps directly include?

#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size.h"

[grt (UTC plus 2), 2017-03-14 09:24:17]

On 2017/03/13 15:29:28, huangs wrote:
> LGTM with NITS.  It seems this also works if user has taskbar dragge to screen
> left/right/top?

Not very well, no. It always positions at the bottom-right of the work area (or
bottom-left for RTL locales). I plan to address the taskbar being on other sides
in a different CL.

https://codereview.chromium.org/2742343002/diff/1/chrome/browser/first_run/tr...
File chrome/browser/first_run/try_chrome_dialog_view.h (right):

https://codereview.chromium.org/2742343002/diff/1/chrome/browser/first_run/tr...
chrome/browser/first_run/try_chrome_dialog_view.h:16: namespace gfx {
On 2017/03/13 15:29:28, huangs wrote:
> Probably should include; please see below.

Done.

https://codereview.chromium.org/2742343002/diff/1/chrome/browser/first_run/tr...
chrome/browser/first_run/try_chrome_dialog_view.h:98: gfx::Rect
ComputeWindowPosition(gfx::Size size, bool is_RTL);
On 2017/03/13 15:29:28, huangs wrote:
> gfx::Rect and gfx::Size are returned / passed by value. This works probably
> because the .h file got included somewhere along the line; and predeclaring
them
> is redundant.  Perhaps directly include?
> 
> #include "ui/gfx/geometry/rect.h"
> #include "ui/gfx/geometry/size.h"

Done.

[grt (UTC plus 2), 2017-03-14 09:24:25]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-03-14 09:24:26]

The patchset sent to the CQ was uploaded after l-g-t-m from huangs@chromium.org
Link to the patchset: https://codereview.chromium.org/2742343002/#ps20001
(title: "iwyu fixes")

[commit-bot: I haz the power, 2017-03-14 09:24:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 10:08:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489483465849440,
"parent_rev": "861f3d1b0afc30dca26fd2ec6a26d92a477654c8", "commit_rev":
"b2dd7ef5625c8ab415c1257d53b7a721dfffc344"}

[commit-bot: I haz the power, 2017-03-14 10:09:15]

Description was changed from

==========
Fix the positioning of the TryChromeDialog when the taskbar is hidden.

In cases of multi-monitor, MonitorFromWindow may return a secondary
monitor depending on the orientation of the monitors, so simply position
the window based on the work area of the primary monitor.

Also fixes a bug in the panic fallback that was improperly increasing
the size of the dialog.

BUG=700857
R=huangs@chromium.org
==========

to

==========
Fix the positioning of the TryChromeDialog when the taskbar is hidden.

In cases of multi-monitor, MonitorFromWindow may return a secondary
monitor depending on the orientation of the monitors, so simply position
the window based on the work area of the primary monitor.

Also fixes a bug in the panic fallback that was improperly increasing
the size of the dialog.

BUG=700857
R=huangs@chromium.org

Review-Url: https://codereview.chromium.org/2742343002
Cr-Commit-Position: refs/heads/master@{#456664}
Committed:
https://chromium.googlesource.com/chromium/src/+/b2dd7ef5625c8ab415c1257d53b7...
==========

[commit-bot: I haz the power, 2017-03-14 10:09:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b2dd7ef5625c8ab415c1257d53b7...