Fix the positioning of the TryChromeDialog when the taskbar is hidden.

chrome/browser/first_run/try_chrome_dialog_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_FIRST_RUN_TRY_CHROME_DIALOG_VIEW_H_
 #define CHROME_BROWSER_FIRST_RUN_TRY_CHROME_DIALOG_VIEW_H_
 
 #include <stddef.h>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/link_listener.h"
 
 namespace gfx {

[huangs, 2017/03/13 15:29:28]

Probably should include; please see below.

[grt (UTC plus 2), 2017/03/14 09:24:17]

Done.

 class Rect;
+class Size;
 }
 
 namespace views {
 class RadioButton;
 class Checkbox;
 class Widget;
 }
 
 // This class displays a modal dialog using the views system. The dialog asks
 // the user to give chrome another try. This class only handles the UI so the
@@ skipping 58 matching lines @@
  private:
   explicit TryChromeDialogView(size_t flavor);
   ~TryChromeDialogView() override;
 
   Result ShowModal(const ActiveModalDialogListener& listener);
 
   // Returns a screen rectangle that is fit to show the window. In particular
   // it has the following properties: a) is visible and b) is attached to the
   // bottom of the working area. For LTR machines it returns a left side
   // rectangle and for RTL it returns a right side rectangle so that the dialog
-  // does not compete with the standar place of the start menu.
-  gfx::Rect ComputeWindowPosition(int width, int height, bool is_RTL);
+  // does not compete with the standard place of the start menu.
+  gfx::Rect ComputeWindowPosition(gfx::Size size, bool is_RTL);

[huangs, 2017/03/13 15:29:28]

gfx::Rect and gfx::Size are returned / passed by value. This works probably
because the .h file got included somewhere along the line; and predeclaring them
is redundant.  Perhaps directly include?

#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size.h"

[grt (UTC plus 2), 2017/03/14 09:24:17]

Done.

 
   // Create a windows region that looks like a toast of width |w| and height
   // |h|. This is best effort, so we don't care much if the operation fails.
   void SetToastRegion(HWND window, int w, int h);
 
   // views::ButtonListener:
   // We have two buttons and according to what the user clicked we set |result_|
   // and we should always close and end the modal loop.
   void ButtonPressed(views::Button* sender, const ui::Event& event) override;
 
@@ skipping 11 matching lines @@
   views::RadioButton* try_chrome_;
   views::RadioButton* kill_chrome_;
   views::RadioButton* dont_try_chrome_;
   views::Checkbox* make_default_;
   Result result_;
 
   DISALLOW_COPY_AND_ASSIGN(TryChromeDialogView);
 };
 
 #endif  // CHROME_BROWSER_FIRST_RUN_TRY_CHROME_DIALOG_VIEW_H_