Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: chrome/browser/first_run/try_chrome_dialog_view.h

Issue 2742343002: Fix the positioning of the TryChromeDialog when the taskbar is hidden. (Closed)
Patch Set: iwyu fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/first_run/try_chrome_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/first_run/try_chrome_dialog_view.h
diff --git a/chrome/browser/first_run/try_chrome_dialog_view.h b/chrome/browser/first_run/try_chrome_dialog_view.h
index 1daa77f5b09642561913ac3deb94e20f551cc192..897b73dbd6bb8b60c7faff2e248597cb698a5c13 100644
--- a/chrome/browser/first_run/try_chrome_dialog_view.h
+++ b/chrome/browser/first_run/try_chrome_dialog_view.h
@@ -9,14 +9,12 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "ui/gfx/geometry/rect.h"
+#include "ui/gfx/geometry/size.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/views/controls/button/button.h"
#include "ui/views/controls/link_listener.h"
-namespace gfx {
-class Rect;
-}
-
namespace views {
class RadioButton;
class Checkbox;
@@ -93,8 +91,8 @@ class TryChromeDialogView : public views::ButtonListener,
// it has the following properties: a) is visible and b) is attached to the
// bottom of the working area. For LTR machines it returns a left side
// rectangle and for RTL it returns a right side rectangle so that the dialog
- // does not compete with the standar place of the start menu.
- gfx::Rect ComputeWindowPosition(int width, int height, bool is_RTL);
+ // does not compete with the standard place of the start menu.
+ gfx::Rect ComputeWindowPosition(gfx::Size size, bool is_RTL);
// Create a windows region that looks like a toast of width |w| and height
// |h|. This is best effort, so we don't care much if the operation fails.
« no previous file with comments | « no previous file | chrome/browser/first_run/try_chrome_dialog_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698