Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2742273002: color: Use classic locale for printing (Closed)

Created:
3 years, 9 months ago by ccameron
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

color: Use classic locale for printing Use std::locale::classic() for printing, and switch to using std::stringstream. This should result in uniform printing across all platforms and locales. BUG=695431 Review-Url: https://codereview.chromium.org/2732583002 Cr-Commit-Position: refs/heads/master@{#454656} (cherry picked from commit bbd39d8f347e826ca50e500130c174130149d68e) Review-Url: https://codereview.chromium.org/2742273002 . Cr-Commit-Position: refs/branch-heads/3029@{#142} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/d824f46455fe24832a980fa4e237de56e40143fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -57 lines) Patch
M ui/gfx/color_transform.cc View 9 chunks +44 lines, -31 lines 0 comments Download
M ui/gfx/color_transform_unittest.cc View 1 chunk +23 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ccameron
3 years, 9 months ago (2017-03-13 07:55:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d824f46455fe24832a980fa4e237de56e40143fe (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698