Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2732583002: color: Use classic locale for printing (Closed)

Created:
3 years, 9 months ago by ccameron
Modified:
3 years, 9 months ago
Reviewers:
hubbe
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Use classic locale for printing Use std::locale::classic() for printing, and switch to using std::stringstream. This should result in uniform printing across all platforms and locales. BUG=695431 Review-Url: https://codereview.chromium.org/2732583002 Cr-Commit-Position: refs/heads/master@{#454656} Committed: https://chromium.googlesource.com/chromium/src/+/bbd39d8f347e826ca50e500130c174130149d68e

Patch Set 1 #

Patch Set 2 : color: Use classic locale for printing #

Patch Set 3 : Modify sstream directly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -57 lines) Patch
M ui/gfx/color_transform.cc View 1 2 9 chunks +44 lines, -31 lines 0 comments Download
M ui/gfx/color_transform_unittest.cc View 1 1 chunk +23 lines, -26 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
ccameron
The fact that there exists an API called "imbue" amuses me.
3 years, 9 months ago (2017-03-03 08:25:22 UTC) #8
hubbe
lgtm
3 years, 9 months ago (2017-03-03 18:55:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732583002/40001
3 years, 9 months ago (2017-03-03 19:12:08 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 20:06:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bbd39d8f347e826ca50e500130c1...

Powered by Google App Engine
This is Rietveld 408576698