Remove special output_dir from cloud_print's BUILD files.

Remove special output_dir from cloud_print's BUILD files.

BUG=697092
Review-Url: https://codereview.chromium.org/2741633003
Cr-Commit-Position: refs/heads/master@{#456061}
Committed: https://chromium.googlesource.com/chromium/src/+/900f63e7d8ec7356108c4e002db8c642314c5455

[pastarmovj, 2017-03-09 15:07:40]

pastarmovj@chromium.org changed reviewers:
+ thakis@chromium.org

[pastarmovj, 2017-03-09 15:07:41]

PTAL. Thanks!

[Nico, 2017-03-09 15:38:31]

Cool, thanks! You can delete
https://cs.chromium.org/chromium/src/cloud_print/DEPS?q=virtual_driver_setup_...
now too.

Do any packaging scripts for installers or whatnot need to be updated? (In some
internal repo maybe? No idea.) If not, lgtm with the DEPS file updated and the
comment below addressed.

https://codereview.chromium.org/2741633003/diff/1/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/win/install/BUILD.gn (right):

https://codereview.chromium.org/2741633003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/install/BUILD.gn:65: # output_dir =
"$root_gen_dir/virtual_driver_setup_resources"
delete

[pastarmovj, 2017-03-10 13:48:29]

no external deps for this file. It is used only in this build target that I
fixed.

https://codereview.chromium.org/2741633003/diff/1/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/win/install/BUILD.gn (right):

https://codereview.chromium.org/2741633003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/install/BUILD.gn:65: # output_dir =
"$root_gen_dir/virtual_driver_setup_resources"
On 2017/03/09 15:38:30, Nico wrote:
> delete

sorry i committed my cleanup when i saw it working and then forgot to upload :)

[pastarmovj, 2017-03-10 13:48:32]

The CQ bit was checked by pastarmovj@chromium.org

[pastarmovj, 2017-03-10 13:48:33]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2741633003/#ps20001
(title: "Remove special output_dir from cloud_print's BUILD files.")

[commit-bot: I haz the power, 2017-03-10 13:48:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-10 13:58:26]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-03-10 13:58:48]

On 2017/03/10 13:48:42, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

You forgot to remove it from the DEPS file

[pastarmovj, 2017-03-10 14:01:07]

oops sorry.

[pastarmovj, 2017-03-10 14:01:26]

The CQ bit was checked by pastarmovj@chromium.org

[pastarmovj, 2017-03-10 14:01:27]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2741633003/#ps40001
(title: "Fix DEPS files.")

[commit-bot: I haz the power, 2017-03-10 14:01:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 15:03:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489154486697510,
"parent_rev": "53f40b0658b240dd7397a58b29b083631519735f", "commit_rev":
"0b8b8b1d31460c7ba0d975461ba4e3019d3bf8c6"}

[commit-bot: I haz the power, 2017-03-10 15:08:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489154486697510,
"parent_rev": "831adc89ff112f7f932a9a6e906ee1b1ce2b771e", "commit_rev":
"900f63e7d8ec7356108c4e002db8c642314c5455"}

[commit-bot: I haz the power, 2017-03-10 15:08:50]

Description was changed from

==========
Remove special output_dir from cloud_print's BUILD files.

BUG=697092
==========

to

==========
Remove special output_dir from cloud_print's BUILD files.

BUG=697092

Review-Url: https://codereview.chromium.org/2741633003
Cr-Commit-Position: refs/heads/master@{#456061}
Committed:
https://chromium.googlesource.com/chromium/src/+/900f63e7d8ec7356108c4e002db8...
==========

[commit-bot: I haz the power, 2017-03-10 15:08:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/900f63e7d8ec7356108c4e002db8...

[Nico, 2017-03-10 15:18:22]

https://codereview.chromium.org/2741633003/diff/40001/cloud_print/virtual_dri...
File cloud_print/virtual_driver/win/install/BUILD.gn (right):

https://codereview.chromium.org/2741633003/diff/40001/cloud_print/virtual_dri...
cloud_print/virtual_driver/win/install/BUILD.gn:65: # output_dir =
"$root_gen_dir/virtual_driver_setup_resources"
this is still commented out...