Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: cloud_print/virtual_driver/win/install/BUILD.gn

Issue 2741633003: Remove special output_dir from cloud_print's BUILD files. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cloud_print/virtual_driver/win/install/setup.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//chrome/process_version_rc_template.gni") 5 import("//chrome/process_version_rc_template.gni")
6 import("//tools/grit/grit_rule.gni") 6 import("//tools/grit/grit_rule.gni")
7 7
8 assert(is_win) 8 assert(is_win)
9 9
10 executable("virtual_driver_setup") { 10 executable("virtual_driver_setup") {
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 output = "$target_gen_dir/virtual_driver_setup.rc" 55 output = "$target_gen_dir/virtual_driver_setup.rc"
56 } 56 }
57 57
58 grit("resources") { 58 grit("resources") {
59 visibility = [ ":*" ] 59 visibility = [ ":*" ]
60 60
61 source = "virtual_driver_setup_resources.grd" 61 source = "virtual_driver_setup_resources.grd"
62 62
63 # TODO(thakis): Consider removing this in favor of the default directory, 63 # TODO(thakis): Consider removing this in favor of the default directory,
64 # https://crbug.com/697092 64 # https://crbug.com/697092
65 output_dir = "$root_gen_dir/virtual_driver_setup_resources" 65 # output_dir = "$root_gen_dir/virtual_driver_setup_resources"
Nico 2017/03/09 15:38:30 delete
pastarmovj 2017/03/10 13:48:29 sorry i committed my cleanup when i saw it working
66 66
67 outputs = [ 67 outputs = [
68 "grit/virtual_driver_setup_resources.h", 68 "grit/virtual_driver_setup_resources.h",
69 "virtual_driver_setup_resources_ar.rc", 69 "virtual_driver_setup_resources_ar.rc",
70 "virtual_driver_setup_resources_bg.rc", 70 "virtual_driver_setup_resources_bg.rc",
71 "virtual_driver_setup_resources_bn.rc", 71 "virtual_driver_setup_resources_bn.rc",
72 "virtual_driver_setup_resources_ca.rc", 72 "virtual_driver_setup_resources_ca.rc",
73 "virtual_driver_setup_resources_cs.rc", 73 "virtual_driver_setup_resources_cs.rc",
74 "virtual_driver_setup_resources_da.rc", 74 "virtual_driver_setup_resources_da.rc",
75 "virtual_driver_setup_resources_de.rc", 75 "virtual_driver_setup_resources_de.rc",
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 "virtual_driver_setup_resources_ta.rc", 113 "virtual_driver_setup_resources_ta.rc",
114 "virtual_driver_setup_resources_te.rc", 114 "virtual_driver_setup_resources_te.rc",
115 "virtual_driver_setup_resources_th.rc", 115 "virtual_driver_setup_resources_th.rc",
116 "virtual_driver_setup_resources_tr.rc", 116 "virtual_driver_setup_resources_tr.rc",
117 "virtual_driver_setup_resources_uk.rc", 117 "virtual_driver_setup_resources_uk.rc",
118 "virtual_driver_setup_resources_vi.rc", 118 "virtual_driver_setup_resources_vi.rc",
119 "virtual_driver_setup_resources_zh-CN.rc", 119 "virtual_driver_setup_resources_zh-CN.rc",
120 "virtual_driver_setup_resources_zh-TW.rc", 120 "virtual_driver_setup_resources_zh-TW.rc",
121 ] 121 ]
122 } 122 }
OLDNEW
« no previous file with comments | « no previous file | cloud_print/virtual_driver/win/install/setup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698