cloud_print/virtual_driver/win/install/BUILD.gn - Issue 2741633003: Remove special output_dir from cloud_print's BUILD files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/virtual_driver/win/install/BUILD.gn

Issue 2741633003: Remove special output_dir from cloud_print's BUILD files. (Closed)

Patch Set: Fix DEPS files. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/virtual_driver/win/install/BUILD.gn

diff --git a/cloud_print/virtual_driver/win/install/BUILD.gn b/cloud_print/virtual_driver/win/install/BUILD.gn

index 2c8fbaa0bcd821c24064c468c7c4f1e76a0524ba..17b7fd2b6be3d599e49fc4e7b44cbe2359e93eab 100644

--- a/cloud_print/virtual_driver/win/install/BUILD.gn

+++ b/cloud_print/virtual_driver/win/install/BUILD.gn

@@ -62,7 +62,7 @@ grit("resources") {

# TODO(thakis): Consider removing this in favor of the default directory,

# https://crbug.com/697092

- output_dir = "$root_gen_dir/virtual_driver_setup_resources"

+ # output_dir = "$root_gen_dir/virtual_driver_setup_resources"

Nico 2017/03/10 15:18:22 this is still commented out...

outputs = [

"grit/virtual_driver_setup_resources.h",

« no previous file with comments | « cloud_print/DEPS ('k') | cloud_print/virtual_driver/win/install/setup.cc » ('j') | no next file with comments »