Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2741053005: [Chrome OS] Clean up BrowserTabStripTracker Init parameter. (Closed)

Created:
3 years, 9 months ago by xdai1
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, devtools-reviews_chromium.org, asvitkine+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chrome OS] Clean up BrowserTabStripTracker Init parameter. HostDesktopType has been removed from BrowserList::GetInstance() in https://codereview.chromium.org/1637943003. So there is no difference for two init types in BrowserTabStripTracker::Init(). Clean this up. BUG=None Review-Url: https://codereview.chromium.org/2741053005 Cr-Commit-Position: refs/heads/master@{#456409} Committed: https://chromium.googlesource.com/chromium/src/+/97132c3f0e88a66d424f47011365bed009d8f78f

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -40 lines) Patch
M chrome/browser/devtools/devtools_auto_opener.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/global_confirm_info_bar.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_event_router.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/metrics/tab_reactivation_tracker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/metrics/tab_usage_recorder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_tracker.h View 2 chunks +7 lines, -13 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_tracker.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_stats_recorder.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
xdai1
sky@, could you help review this CL please? Thanks!
3 years, 9 months ago (2017-03-11 00:21:14 UTC) #4
sky
LGTM
3 years, 9 months ago (2017-03-13 15:42:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741053005/20001
3 years, 9 months ago (2017-03-13 16:25:14 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 17:12:33 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97132c3f0e88a66d424f47011365...

Powered by Google App Engine
This is Rietveld 408576698