Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2847)

Unified Diff: chrome/browser/ui/browser_tab_strip_tracker.h

Issue 2741053005: [Chrome OS] Clean up BrowserTabStripTracker Init parameter. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_tab_strip_tracker.h
diff --git a/chrome/browser/ui/browser_tab_strip_tracker.h b/chrome/browser/ui/browser_tab_strip_tracker.h
index b23076446b9b2c5e506663327d20c6659b8b9696..1f84ac5e719214de7e185b434c607d2c44bec5ac 100644
--- a/chrome/browser/ui/browser_tab_strip_tracker.h
+++ b/chrome/browser/ui/browser_tab_strip_tracker.h
@@ -28,12 +28,6 @@ class TabStripModelObserver;
// should be tracked.
class BrowserTabStripTracker : public chrome::BrowserListObserver {
public:
- // See Init() for details.
- enum class InitWith {
- BROWSERS_IN_ACTIVE_DESKTOP,
- ALL_BROWERS,
- };
-
// See class description for details. You only need specify a
// TabStripModelObserver. |delegate| and |browser_list_observer| are
// optional.
@@ -43,13 +37,13 @@ class BrowserTabStripTracker : public chrome::BrowserListObserver {
~BrowserTabStripTracker() override;
// Starts tracking BrowserList for changes and additionally observes the
- // existing Browsers matching |init_with|. If there is a
- // BrowserTabStripTrackerDelegate it is called to determine if the Browser
- // should be observed. If an existing Browser should be observed
- // TabInsertedAt() is called for any existing tabs. If a delegate needs to
- // differentiate between Browsers observed by way of Init() vs. a Browser
- // added after the fact use is_processing_initial_browsers().
- void Init(InitWith init_with);
+ // existing Browsers. If there is a BrowserTabStripTrackerDelegate it is
+ // called to determine if the Browser should be observed. If an existing
+ // Browser should be observed TabInsertedAt() is called for any existing tabs.
+ // If a delegate needs to differentiate between Browsers observed by way of
+ // Init() vs. a Browser added after the fact use
+ // is_processing_initial_browsers().
+ void Init();
// Returns true if processing an existing Browser in Init().
bool is_processing_initial_browsers() const {
« no previous file with comments | « chrome/browser/ui/ash/launcher/browser_status_monitor.cc ('k') | chrome/browser/ui/browser_tab_strip_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698