Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance() (Closed)

Created:
4 years, 11 months ago by scottmg
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, tfarina, jam, dcheng, rginda+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@screen-wrapper-land
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from BrowserList::GetInstance() And make GetHostDesktopTypeForNativeView/Window and GetActiveDesktop() no-ops. R=sky@chromium.org BUG=558054 Committed: https://crrev.com/0d8e4abea75d78a0ebc0631ade61b9b70bc86fb1 Cr-Commit-Position: refs/heads/master@{#371938}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove unnecessary args from AddTabStats #

Patch Set 3 : fix rebase #

Patch Set 4 : cros/linux/mac #

Patch Set 5 : more mac #

Patch Set 6 : mac #

Patch Set 7 : mac2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -560 lines) Patch
M chrome/browser/app_controller_mac_browsertest.mm View 1 2 3 4 5 4 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/apps/install_chrome_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 2 3 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/restore_on_startup_browsertest_chromeos.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/offscreen_tab.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager.h View 1 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/memory/tab_manager.cc View 1 3 chunks +7 lines, -21 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_list_desktop_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_window_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_browsertest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 2 3 3 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 2 3 4 chunks +14 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 3 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/media_delegate_chromeos.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_finder.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_iterator.h View 2 chunks +11 lines, -23 lines 0 comments Download
M chrome/browser/ui/browser_iterator.cc View 1 chunk +5 lines, -17 lines 0 comments Download
D chrome/browser/ui/browser_iterator_unittest.cc View 1 chunk +0 lines, -127 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 5 chunks +7 lines, -16 lines 0 comments Download
M chrome/browser/ui/browser_tab_restorer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_tracker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabrestore_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 2 3 4 5 6 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/host_desktop.h View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/host_desktop.cc View 1 chunk +3 lines, -53 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc View 4 chunks +4 lines, -24 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 2 3 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 22 chunks +39 lines, -41 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 3 chunks +3 lines, -48 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
scottmg
I had to do just this little bit at a time. Removing host_desktop.h in one ...
4 years, 11 months ago (2016-01-26 22:56:07 UTC) #1
sky
https://codereview.chromium.org/1637943003/diff/1/chrome/browser/memory/tab_manager.cc File chrome/browser/memory/tab_manager.cc (right): https://codereview.chromium.org/1637943003/diff/1/chrome/browser/memory/tab_manager.cc#newcode209 chrome/browser/memory/tab_manager.cc:209: AddTabStats(BrowserList::GetInstance(), true, &stats_list); Can you remove BrowserList as an ...
4 years, 11 months ago (2016-01-27 02:41:44 UTC) #2
scottmg
https://codereview.chromium.org/1637943003/diff/1/chrome/browser/memory/tab_manager.cc File chrome/browser/memory/tab_manager.cc (right): https://codereview.chromium.org/1637943003/diff/1/chrome/browser/memory/tab_manager.cc#newcode209 chrome/browser/memory/tab_manager.cc:209: AddTabStats(BrowserList::GetInstance(), true, &stats_list); On 2016/01/27 02:41:44, sky wrote: > ...
4 years, 11 months ago (2016-01-27 18:10:32 UTC) #3
sky
LGTM
4 years, 11 months ago (2016-01-27 19:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637943003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637943003/120001
4 years, 11 months ago (2016-01-27 23:44:08 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 11 months ago (2016-01-28 00:35:02 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 00:36:57 UTC) #10
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/0d8e4abea75d78a0ebc0631ade61b9b70bc86fb1
Cr-Commit-Position: refs/heads/master@{#371938}

Powered by Google App Engine
This is Rietveld 408576698