Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2741023002: Migrate WTF::Deque::removeLast() to ::pop_back() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, Mikhail, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Deque::removeLast() to ::pop_back() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2741023002 Cr-Commit-Position: refs/heads/master@{#455969} Committed: https://chromium.googlesource.com/chromium/src/+/9c002f2da505ce41c638412a8ede39e24249e7dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/DequeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 9 months ago (2017-03-09 18:32:09 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-09 21:49:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741023002/1
3 years, 9 months ago (2017-03-10 02:48:45 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 03:00:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c002f2da505ce41c638412a8ede...

Powered by Google App Engine
This is Rietveld 408576698