Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: third_party/WebKit/Source/wtf/DequeTest.cpp

Issue 2741023002: Migrate WTF::Deque::removeLast() to ::pop_back() (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/Deque.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 EXPECT_EQ(1, *deque[2]); 520 EXPECT_EQ(1, *deque[2]);
521 EXPECT_EQ(2, *deque[3]); 521 EXPECT_EQ(2, *deque[3]);
522 522
523 Pointer first(deque.takeFirst()); 523 Pointer first(deque.takeFirst());
524 EXPECT_EQ(-2, *first); 524 EXPECT_EQ(-2, *first);
525 Pointer last(deque.takeLast()); 525 Pointer last(deque.takeLast());
526 EXPECT_EQ(2, *last); 526 EXPECT_EQ(2, *last);
527 527
528 EXPECT_EQ(2u, deque.size()); 528 EXPECT_EQ(2u, deque.size());
529 deque.removeFirst(); 529 deque.removeFirst();
530 deque.removeLast(); 530 deque.pop_back();
531 EXPECT_EQ(0u, deque.size()); 531 EXPECT_EQ(0u, deque.size());
532 532
533 deque.append(Pointer(new int(42))); 533 deque.append(Pointer(new int(42)));
534 deque[0] = Pointer(new int(24)); 534 deque[0] = Pointer(new int(24));
535 ASSERT_EQ(1u, deque.size()); 535 ASSERT_EQ(1u, deque.size());
536 EXPECT_EQ(24, *deque[0]); 536 EXPECT_EQ(24, *deque[0]);
537 537
538 deque.clear(); 538 deque.clear();
539 } 539 }
540 540
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 EXPECT_EQ(2u, deque.size()); 629 EXPECT_EQ(2u, deque.size());
630 EXPECT_EQ(3, deque[0].value1); 630 EXPECT_EQ(3, deque[0].value1);
631 EXPECT_EQ(4, deque[0].value2); 631 EXPECT_EQ(4, deque[0].value2);
632 EXPECT_EQ(1, deque[1].value1); 632 EXPECT_EQ(1, deque[1].value1);
633 EXPECT_EQ(2, deque[1].value2); 633 EXPECT_EQ(2, deque[1].value2);
634 } 634 }
635 635
636 } // anonymous namespace 636 } // anonymous namespace
637 637
638 } // namespace WTF 638 } // namespace WTF
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/wtf/Deque.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698