third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp - Issue 2741023002: Migrate WTF::Deque::removeLast() to ::pop_back()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp

Issue 2741023002: Migrate WTF::Deque::removeLast() to ::pop_back() (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp b/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp

index 8390f58b9562cab9b72e64e95e2f0706cf91666e..0664966c9f64939c24d3a48ef26f305c81dbefaf 100644

--- a/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp

+++ b/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp

@@ -200,7 +200,7 @@ void ScriptRunIterator::closeBracket(UChar32 ch) {

int numPopped = std::distance(m_brackets.rbegin(), it);

// TODO: No resize operation in WTF::Deque?

for (int i = 0; i < numPopped; ++i)

- m_brackets.removeLast();

+ m_brackets.pop_back();

m_bracketsFixupDepth =

std::max(static_cast<size_t>(0), m_bracketsFixupDepth - numPopped);

return;