[DevTools] Simplify Popover API

[DevTools] Simplify Popover API

Removed Popover class (it is just a GlassPane now) and merged remaining bits into PopoverHelper.
Also started using promises for resolving.

Next step would be to rename PopoverHelper into Popover and replace three callbacks
with a callback + promise.

BUG=none

Review-Url: https://codereview.chromium.org/2740803002
Cr-Commit-Position: refs/heads/master@{#456260}
Committed: https://chromium.googlesource.com/chromium/src/+/fc4bb36920dc06b4c961e32dfab83ecc30fd2561

[dgozman, 2017-03-10 19:24:10]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 19:24:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-03-10 19:28:52]

Description was changed from

==========
[DevTools] Simplify Popover api.

BUG=none
==========

to

==========
[DevTools] Simplify Popover API

Removed Popover class (it is just a GlassPane now) and merged remaining bits
into PopoverHelper.
Also started using promises for resolving.

Next step would be to rename PopoverHelper into Popover and replace three
callbacks
with a callback + promise.

BUG=none
==========

[dgozman, 2017-03-10 19:29:07]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2017-03-10 19:29:08]

Could you please take a look?

[commit-bot: I haz the power, 2017-03-10 21:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:28:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2017-03-10 22:07:14]

lgtm

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html
(right):

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html:62:
return !!document.body.querySelector('* /deep/ .spectrum-color');
fyi: /deep/ is deprecated

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/inline_editor/SwatchPopoverHelper.js
(right):

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/inline_editor/SwatchPopoverHelper.js:11:
this._popover.registerRequiredCSS('ui/popover.css');
should we have a helper method createPopover() which will do this five lines of
code? i feel uneasy with the need to register css from other module

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Popover.js (right):

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Popover.js:200: if
(UI.PopoverHelper._popover)
let's console.error as well to track and investigate this scenario

[dgozman, 2017-03-11 00:00:44]

Thanks!

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html
(right):

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html:62:
return !!document.body.querySelector('* /deep/ .spectrum-color');
On 2017/03/10 22:07:14, lushnikov wrote:
> fyi: /deep/ is deprecated

Yeah :-)

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/inline_editor/SwatchPopoverHelper.js
(right):

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/inline_editor/SwatchPopoverHelper.js:11:
this._popover.registerRequiredCSS('ui/popover.css');
On 2017/03/10 22:07:14, lushnikov wrote:
> should we have a helper method createPopover() which will do this five lines
of
> code? i feel uneasy with the need to register css from other module

I'll copy over the css. The rest lines are GlassPane's API, which they should
call separately.

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Popover.js (right):

https://codereview.chromium.org/2740803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Popover.js:200: if
(UI.PopoverHelper._popover)
On 2017/03/10 22:07:14, lushnikov wrote:
> let's console.error as well to track and investigate this scenario

Done.

[dgozman, 2017-03-11 00:00:50]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 00:01:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 01:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 01:39:49]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-03-11 02:17:58]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-03-11 02:17:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2740803002/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-11 02:18:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 02:22:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489198678796660,
"parent_rev": "67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891", "commit_rev":
"fc4bb36920dc06b4c961e32dfab83ecc30fd2561"}

[commit-bot: I haz the power, 2017-03-11 02:23:25]

Description was changed from

==========
[DevTools] Simplify Popover API

Removed Popover class (it is just a GlassPane now) and merged remaining bits
into PopoverHelper.
Also started using promises for resolving.

Next step would be to rename PopoverHelper into Popover and replace three
callbacks
with a callback + promise.

BUG=none
==========

to

==========
[DevTools] Simplify Popover API

Removed Popover class (it is just a GlassPane now) and merged remaining bits
into PopoverHelper.
Also started using promises for resolving.

Next step would be to rename PopoverHelper into Popover and replace three
callbacks
with a callback + promise.

BUG=none

Review-Url: https://codereview.chromium.org/2740803002
Cr-Commit-Position: refs/heads/master@{#456260}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc4bb36920dc06b4c961e32dfab8...
==========

[commit-bot: I haz the power, 2017-03-11 02:23:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fc4bb36920dc06b4c961e32dfab8...