Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

Issue 2740803002: [DevTools] Simplify Popover API (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js
index f3e5010b51a96d5c091eee59b8a7504545f26b4f..4194f9928b62ef0e871a20f9196b91f6feab6442 100644
--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js
@@ -56,6 +56,7 @@ PerfUI.TimelineOverviewPane = class extends UI.VBox {
this._popoverHelper = new UI.PopoverHelper(this._cursorArea);
this._popoverHelper.initializeCallbacks(
this._getPopoverAnchor.bind(this), this._showPopover.bind(this), this._onHidePopover.bind(this));
+ this._popoverHelper.setHasPadding(true);
this._popoverHelper.setTimeout(0);
this._updateThrottler = new Common.Throttler(100);
@@ -76,22 +77,26 @@ PerfUI.TimelineOverviewPane = class extends UI.VBox {
/**
* @param {!Element} anchor
- * @param {!UI.Popover} popover
+ * @param {!UI.GlassPane} popover
+ * @return {!Promise<boolean>}
*/
_showPopover(anchor, popover) {
- this._buildPopoverContents().then(maybeShowPopover.bind(this));
+ return this._buildPopoverContents().then(maybeShowPopover.bind(this));
+
/**
* @this {PerfUI.TimelineOverviewPane}
* @param {!DocumentFragment} fragment
+ * @return {boolean}
*/
function maybeShowPopover(fragment) {
if (!fragment.firstChild)
- return;
+ return false;
var content = new PerfUI.TimelineOverviewPane.PopoverContents();
this._popoverContents = content.contentElement.createChild('div');
this._popoverContents.appendChild(fragment);
this._popover = popover;
- popover.showView(content, this._cursorElement);
+ content.show(popover.contentElement);
+ return true;
}
}

Powered by Google App Engine
This is Rietveld 408576698