[DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper.

[DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper.

Turned it into a real helper, so that clients talk to PopoverHelper
directly. This makes further refactorings easier and streamlines
the control flow.

BUG=none

Review-Url: https://codereview.chromium.org/2745903003
Cr-Commit-Position: refs/heads/master@{#456500}
Committed: https://chromium.googlesource.com/chromium/src/+/3aad9dc139f13ba77c5feb67feb4610f3a2c70b0

[dgozman, 2017-03-11 00:53:01]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2017-03-11 00:53:01]

Could you please take a look?

[dgozman, 2017-03-13 05:46:21]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 05:46:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 07:28:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 07:28:53]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2017-03-13 17:55:03]

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
(right):

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js:35:
constructor() {
let's create an instnace with popover and remote object

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js:44:
buildObjectPopover(result, popover) {
maybe you can even make this a static factory which returns
Promise<ObjectPopoverHelper>

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js:102:
if (result.type !== 'object') {
brief examination didn't reveal any code changes here - is it just a move?

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:484:
// Popover may have been removed by callback().
since with your change the callback will run in a subsequent microtask - this
code never happens.

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:507:
this._objectPopoverHelper.dispose();
the this._objectPopoverHelper is created in the JSSF constructoror - we either
don't want to dispose it on every popover hide,
or we want to re-create it on every showPopover

[dgozman, 2017-03-13 19:57:18]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2017-03-13 19:57:24]

PTAL

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
(right):

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js:35:
constructor() {
On 2017/03/13 17:55:02, lushnikov wrote:
> let's create an instnace with popover and remote object

Done.

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js:44:
buildObjectPopover(result, popover) {
On 2017/03/13 17:55:02, lushnikov wrote:
> maybe you can even make this a static factory which returns
> Promise<ObjectPopoverHelper>

Done.

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js:102:
if (result.type !== 'object') {
On 2017/03/13 17:55:02, lushnikov wrote:
> brief examination didn't reveal any code changes here - is it just a move? 

Exactly.

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:484:
// Popover may have been removed by callback().
On 2017/03/13 17:55:02, lushnikov wrote:
> since with your change the callback will run in a subsequent microtask - this
> code never happens.

Done.

https://codereview.chromium.org/2745903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:507:
this._objectPopoverHelper.dispose();
On 2017/03/13 17:55:02, lushnikov wrote:
> the this._objectPopoverHelper is created in the JSSF constructoror - we either
> don't want to dispose it on every popover hide,
> or we want to re-create it on every showPopover

Done.

[commit-bot: I haz the power, 2017-03-13 19:57:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-03-13 20:16:39]

the code is lgtm

could you please briefly describe where we're heading?

[dgozman, 2017-03-13 21:31:54]

On 2017/03/13 20:16:39, lushnikov wrote:
> the code is lgtm
> 
> could you please briefly describe where we're heading?

I want to slightly improve Popover API to guarantee that show/hide methods are
always called in pair and we use promises for asynchronous resolving when
building popover contents.

[dgozman, 2017-03-13 21:31:58]

The CQ bit was unchecked by dgozman@chromium.org

[dgozman, 2017-03-13 21:32:02]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-03-13 21:32:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 22:04:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489440722842730,
"parent_rev": "7d5e4125a792e09524a5942e829f2cfe738aa253", "commit_rev":
"3aad9dc139f13ba77c5feb67feb4610f3a2c70b0"}

[commit-bot: I haz the power, 2017-03-13 22:05:15]

Description was changed from

==========
[DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper.

Turned it into a real helper, so that clients talk to PopoverHelper
directly. This makes further refactorings easier and streamlines
the control flow.

BUG=none
==========

to

==========
[DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper.

Turned it into a real helper, so that clients talk to PopoverHelper
directly. This makes further refactorings easier and streamlines
the control flow.

BUG=none

Review-Url: https://codereview.chromium.org/2745903003
Cr-Commit-Position: refs/heads/master@{#456500}
Committed:
https://chromium.googlesource.com/chromium/src/+/3aad9dc139f13ba77c5feb67feb4...
==========

[commit-bot: I haz the power, 2017-03-13 22:05:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3aad9dc139f13ba77c5feb67feb4...