Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2740783005: Revert of Update DevTools animation timeline to handle TransitionKeyframeEffectModels (Closed)

Created:
3 years, 9 months ago by fserb
Modified:
3 years, 9 months ago
CC:
samli, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update DevTools animation timeline to handle TransitionKeyframeEffectModels (patchset #2 id:20001 of https://codereview.chromium.org/2732223002/ ) Reason for revert: This test has been consistently failing on Mac 10.11 (dbg). Sorry for reverting this, but please fix it and re-publish. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29 Original issue's description: > Update DevTools animation timeline to handle TransitionKeyframeEffectModels > > CSS Transitions was refactored to use TransitionKeyframes instead of > AnimatableValueKeyframes in https://codereview.chromium.org/2680923005. > This patch updates the DevTools animation timeline to handle the new > data type for transitions. > > BUG=698669 > > Review-Url: https://codereview.chromium.org/2732223002 > Cr-Commit-Position: refs/heads/master@{#455333} > Committed: https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199f7679edc5197 TBR=dgozman@chromium.org,samli@chromium.org,alancutter@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=698669 Review-Url: https://codereview.chromium.org/2740783005 Cr-Commit-Position: refs/heads/master@{#455865} Committed: https://chromium.googlesource.com/chromium/src/+/25402621d78f7cad11d719a55f6e68ca81678108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -56 lines) Patch
D third_party/WebKit/LayoutTests/inspector/animation/animation-transition-setTiming-crash.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/animation/animation-transition-setTiming-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
fserb
Created Revert of Update DevTools animation timeline to handle TransitionKeyframeEffectModels
3 years, 9 months ago (2017-03-09 19:55:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740783005/1
3 years, 9 months ago (2017-03-09 19:56:06 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 21:19:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25402621d78f7cad11d719a55f6e...

Powered by Google App Engine
This is Rietveld 408576698