Update DevTools animation timeline to handle TransitionKeyframeEffectModels

Update DevTools animation timeline to handle TransitionKeyframeEffectModels

CSS Transitions was refactored to use TransitionKeyframes instead of
AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
This patch updates the DevTools animation timeline to handle the new
data type for transitions.

BUG=698669
Review-Url: https://codereview.chromium.org/2732223002
Cr-Original-Original-Commit-Position: refs/heads/master@{#455333}
Committed: https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199f7679edc5197
Review-Url: https://codereview.chromium.org/2732223002
Cr-Original-Commit-Position: refs/heads/master@{#455995}
Committed: https://chromium.googlesource.com/chromium/src/+/d20b39ee5745592e03e549d4576783ae03f5d3a9
Review-Url: https://codereview.chromium.org/2732223002
Cr-Commit-Position: refs/heads/master@{#456335}
Committed: https://chromium.googlesource.com/chromium/src/+/1dc2dcdc62ad67cea55a8bfc94160bc50d3311c2

[alancutter (OOO until 2018), 2017-03-07 07:01:30]

alancutter@chromium.org changed reviewers:
+ dgozman@chromium.org

[alancutter (OOO until 2018), 2017-03-07 07:01:35]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 07:03:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 09:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 09:27:25]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[samli, 2017-03-07 17:54:24]

samli@chromium.org changed reviewers:
+ samli@chromium.org

[samli, 2017-03-07 17:54:25]

lgtm

https://codereview.chromium.org/2732223002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/animation/animation-transition-setTiming-crash.html
(right):

https://codereview.chromium.org/2732223002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/animation/animation-transition-setTiming-crash.html:13:
node.style.left = '100px';
Nit: double quotes "100px"

[dgozman, 2017-03-07 19:53:51]

lgtm

[alancutter (OOO until 2018), 2017-03-07 23:44:48]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-03-07 23:44:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, samli@chromium.org
Link to the patchset: https://codereview.chromium.org/2732223002/#ps20001
(title: "quotes")

[commit-bot: I haz the power, 2017-03-07 23:45:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:47:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488930288540540,
"parent_rev": "3ce2eb3e3bfb42a0147b651a3d4e191285c4a3ec", "commit_rev":
"a7a57ecd7c36b7bd579d45e0f199f7679edc5197"}

[commit-bot: I haz the power, 2017-03-08 01:48:58]

Description was changed from

==========
Update DevTools animation timeline to handle TransitionKeyframeEffectModels

CSS Transitions was refactored to use TransitionKeyframes instead of
AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
This patch updates the DevTools animation timeline to handle the new
data type for transitions.

BUG=698669
==========

to

==========
Update DevTools animation timeline to handle TransitionKeyframeEffectModels

CSS Transitions was refactored to use TransitionKeyframes instead of
AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
This patch updates the DevTools animation timeline to handle the new
data type for transitions.

BUG=698669

Review-Url: https://codereview.chromium.org/2732223002
Cr-Commit-Position: refs/heads/master@{#455333}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199...
==========

[commit-bot: I haz the power, 2017-03-08 01:48:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199...

[fserb, 2017-03-09 19:55:39]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2740783005/ by fserb@chromium.org.

The reason for reverting is: This test has been consistently failing on Mac
10.11 (dbg).

Sorry for reverting this, but please fix it and re-publish.

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1....

[alancutter (OOO until 2018), 2017-03-10 02:24:03]

On 2017/03/09 at 19:55:39, fserb wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2740783005/ by fserb@chromium.org.
> 
> The reason for reverting is: This test has been consistently failing on Mac
10.11 (dbg).
> 
> Sorry for reverting this, but please fix it and re-publish.
> 
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1....

Looks like it times out on slower platforms. Perhaps the transition is never
starting.
Changed test to deterministically start the transitions without relying on an
initial style resolve to have occurred before startCSSTransition() is called.

[alancutter (OOO until 2018), 2017-03-10 02:24:26]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-03-10 02:24:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, samli@chromium.org
Link to the patchset: https://codereview.chromium.org/2732223002/#ps40001
(title: "Fix timeout attempt")

[commit-bot: I haz the power, 2017-03-10 02:25:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 04:25:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489112666009120,
"parent_rev": "368901b0060c0dfc90787fcf47351b0b4ab262c3", "commit_rev":
"d20b39ee5745592e03e549d4576783ae03f5d3a9"}

[commit-bot: I haz the power, 2017-03-10 04:26:12]

Description was changed from

==========
Update DevTools animation timeline to handle TransitionKeyframeEffectModels

CSS Transitions was refactored to use TransitionKeyframes instead of
AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
This patch updates the DevTools animation timeline to handle the new
data type for transitions.

BUG=698669

Review-Url: https://codereview.chromium.org/2732223002
Cr-Commit-Position: refs/heads/master@{#455333}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199...
==========

to

==========
Update DevTools animation timeline to handle TransitionKeyframeEffectModels

CSS Transitions was refactored to use TransitionKeyframes instead of
AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
This patch updates the DevTools animation timeline to handle the new
data type for transitions.

BUG=698669

Review-Url: https://codereview.chromium.org/2732223002
Cr-Original-Commit-Position: refs/heads/master@{#455333}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199...
Review-Url: https://codereview.chromium.org/2732223002
Cr-Commit-Position: refs/heads/master@{#455995}
Committed:
https://chromium.googlesource.com/chromium/src/+/d20b39ee5745592e03e549d45767...
==========

[commit-bot: I haz the power, 2017-03-10 04:26:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d20b39ee5745592e03e549d45767...

[kinuko, 2017-03-10 07:52:01]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2738983005/ by kinuko@chromium.org.

The reason for reverting is: Looks like the test still keeps failing on
Mac10.11.  Could look into this?

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28....

[alancutter (OOO until 2018), 2017-03-13 06:28:29]

On 2017/03/10 at 07:52:01, kinuko wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2738983005/ by kinuko@chromium.org.
> 
> The reason for reverting is: Looks like the test still keeps failing on
Mac10.11.  Could look into this?
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28....

Thanks for the revert. I'm just going to set expectations for this one. I'm just
after any code coverage at all, platform coverage isn't important here. It's
unclear to me what's causing the timeout, probably something to do with being an
inspector test communicating asynchronously across the two sides.
Created crbug.com/700795 to deal with the timeouts.

[alancutter (OOO until 2018), 2017-03-13 06:28:40]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-03-13 06:28:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, samli@chromium.org
Link to the patchset: https://codereview.chromium.org/2732223002/#ps60001
(title: "timout-expectations")

[commit-bot: I haz the power, 2017-03-13 06:28:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 08:07:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489386520774980,
"parent_rev": "214dd7fe513f8d06e76644c08db75fd8d3355d65", "commit_rev":
"1dc2dcdc62ad67cea55a8bfc94160bc50d3311c2"}

[commit-bot: I haz the power, 2017-03-13 08:08:16]

Description was changed from

==========
Update DevTools animation timeline to handle TransitionKeyframeEffectModels

CSS Transitions was refactored to use TransitionKeyframes instead of
AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
This patch updates the DevTools animation timeline to handle the new
data type for transitions.

BUG=698669

Review-Url: https://codereview.chromium.org/2732223002
Cr-Original-Commit-Position: refs/heads/master@{#455333}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199...
Review-Url: https://codereview.chromium.org/2732223002
Cr-Commit-Position: refs/heads/master@{#455995}
Committed:
https://chromium.googlesource.com/chromium/src/+/d20b39ee5745592e03e549d45767...
==========

to

==========
Update DevTools animation timeline to handle TransitionKeyframeEffectModels

CSS Transitions was refactored to use TransitionKeyframes instead of
AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
This patch updates the DevTools animation timeline to handle the new
data type for transitions.

BUG=698669

Review-Url: https://codereview.chromium.org/2732223002
Cr-Original-Original-Commit-Position: refs/heads/master@{#455333}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199...
Review-Url: https://codereview.chromium.org/2732223002
Cr-Original-Commit-Position: refs/heads/master@{#455995}
Committed:
https://chromium.googlesource.com/chromium/src/+/d20b39ee5745592e03e549d45767...
Review-Url: https://codereview.chromium.org/2732223002
Cr-Commit-Position: refs/heads/master@{#456335}
Committed:
https://chromium.googlesource.com/chromium/src/+/1dc2dcdc62ad67cea55a8bfc9416...
==========

[commit-bot: I haz the power, 2017-03-13 08:08:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1dc2dcdc62ad67cea55a8bfc9416...